Dduvall has uploaded a new change for review.
https://gerrit.wikimedia.org/r/197804
Change subject: plugin: Fixed `vagrant roles list -e` with no roles enabled
......................................................................
plugin: Fixed `vagrant roles list -e` with no roles enabled
Avoid "invalid slice" exception by checking whether any roles are given
to print.
Change-Id: Iba10ee559c89351e6af829c70bb2977241e76b26
---
M lib/mediawiki-vagrant/roles/list.rb
1 file changed, 7 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/vagrant
refs/changes/04/197804/1
diff --git a/lib/mediawiki-vagrant/roles/list.rb
b/lib/mediawiki-vagrant/roles/list.rb
index c7ed915..e951105 100644
--- a/lib/mediawiki-vagrant/roles/list.rb
+++ b/lib/mediawiki-vagrant/roles/list.rb
@@ -54,6 +54,7 @@
def show_enabled(opts)
@env.ui.info "Enabled roles:\n" if opts[:verbose]
roles = @mwv.roles_enabled
+
if opts[:single_col]
roles.each { |x| @env.ui.info x }
else
@@ -86,10 +87,12 @@
end
def print_cols(roles)
- col, *cols = roles.each_slice((roles.size/3.0).ceil).to_a
- col.zip(*cols) { |a,b,c|
- @env.ui.info sprintf("%-26s %-26s %-26s", a, b, c)
- }
+ if roles.any?
+ col, *cols = roles.each_slice((roles.size/3.0).ceil).to_a
+ col.zip(*cols) { |a,b,c|
+ @env.ui.info sprintf("%-26s %-26s %-26s", a, b, c)
+ }
+ end
end
end
end
--
To view, visit https://gerrit.wikimedia.org/r/197804
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iba10ee559c89351e6af829c70bb2977241e76b26
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/vagrant
Gerrit-Branch: master
Gerrit-Owner: Dduvall <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
