Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/197820
Change subject: mw-set-env: Use BUILDL_TAG instead of `basename $WORKSPACE`
......................................................................
mw-set-env: Use BUILDL_TAG instead of `basename $WORKSPACE`
WORKSPACE = JOB_NAME [ @ CONCURRENT ]
BUILD_TAG = JOB_NAME + BUILD_NUMBER
More unique (in that future builds will re-use the same workspace
but not the same build tag), and standardised.
And safer. If for whatever reason it wasn't removed,
it will start fresh.
Change-Id: I85a5f8814873e2aa2b56da2fdab815cdcfcfa61e
---
M bin/mw-set-env.sh
1 file changed, 1 insertion(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/integration/jenkins
refs/changes/20/197820/1
diff --git a/bin/mw-set-env.sh b/bin/mw-set-env.sh
index b1f651a..89570ac 100755
--- a/bin/mw-set-env.sh
+++ b/bin/mw-set-env.sh
@@ -18,9 +18,7 @@
# All slaves should have tmpfs mounted, use if available
if [ -d "$HOME/tmpfs" ]; then
# Don't use JOB_NAME since that is not unique when running concurrent
builds (T91070).
- # Instead use the trailing part of $WORKSPACE which will be 'foo',
'foo@2'.
- # Trailing slash is important there.
- export TMPDIR="$HOME/tmpfs/`basename $WORKSPACE`"
+ export TMPDIR="$HOME/tmpfs/$BUILD_TAG"
export MW_TMPDIR="$TMPDIR"
else
export MW_TMPDIR="$WORKSPACE/data"
--
To view, visit https://gerrit.wikimedia.org/r/197820
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I85a5f8814873e2aa2b56da2fdab815cdcfcfa61e
Gerrit-PatchSet: 1
Gerrit-Project: integration/jenkins
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
