jenkins-bot has submitted this change and it was merged.
Change subject: Design tweaks for enter new collection
......................................................................
Design tweaks for enter new collection
* Center creation form
* Add placeholder text
Bug: T92037
Change-Id: I79330e8f41ea55798a2ea510432491a2e613b02e
---
M extension.json
M i18n/en.json
M i18n/qqq.json
M resources/Resources.php
M resources/ext.gather.watchstar/CollectionsContentOverlay.js
M resources/ext.gather.watchstar/content.hogan
M resources/ext.gather.watchstar/contentOverlay.less
7 files changed, 9 insertions(+), 1 deletion(-)
Approvals:
Jhernandez: Looks good to me, approved
jenkins-bot: Verified
diff --git a/extension.json b/extension.json
index 50534a5..f112a51 100644
--- a/extension.json
+++ b/extension.json
@@ -137,6 +137,7 @@
],
"messages": [
"gather-add-to-existing",
+ "gather-add-new-placeholder",
"gather-watchlist-title",
"gather-add-toast",
"gather-remove-toast",
diff --git a/i18n/en.json b/i18n/en.json
index ae4a6d7..86f8582 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -19,6 +19,7 @@
"gather-collection-non-member": "Is not member of collection.",
"gather-anon-cta": "Add this page to a collection that you can share
with the world.",
"gather-create-new-button-label": "Create",
+ "gather-add-new-placeholder": "Enter a new collection name",
"gather-add-to-new": "Add to new collection",
"gather-add-to-existing": "Add to existing collection",
"gather-add-toast": "The page has been added to your \"$1\"
collection.",
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 7e0a29c..14694e1 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -22,6 +22,7 @@
"gather-collection-non-member": "Alternative text displayed next to
collection name when page is not a member.",
"gather-anon-cta": "Message that shows to anonymous users when they
click the add to collection button.",
"gather-create-new-button-label": "Label for a button that is used to
create a new collection.\n{{Identical|Create}}",
+ "gather-add-new-placeholder": "Placeholder text for input field for new
collection.",
"gather-add-to-new": "Heading that shows in the watchstar content
overlay above a form to create a new collection.",
"gather-add-to-existing": "Heading that shows in the watchstar content
overlay above a list of your existing collections.",
"gather-add-toast": "Message displayed when you add an item to a
collection. Parameters:\n* $1 - Name of collection.",
diff --git a/resources/Resources.php b/resources/Resources.php
index 39e661a..2f25098 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -121,6 +121,7 @@
'gather-create-new-button-label',
'gather-add-to-new',
'gather-collection-non-member',
+ 'gather-add-new-placeholder',
),
'templates' => array(
'content.hogan' => 'ext.gather.watchstar/content.hogan',
diff --git a/resources/ext.gather.watchstar/CollectionsContentOverlay.js
b/resources/ext.gather.watchstar/CollectionsContentOverlay.js
index faec3ad..ad04c84 100644
--- a/resources/ext.gather.watchstar/CollectionsContentOverlay.js
+++ b/resources/ext.gather.watchstar/CollectionsContentOverlay.js
@@ -49,6 +49,7 @@
title: mw.config.get( 'wgTitle' ),
spinner: icons.spinner().toHtmlString(),
createButtonLabel: mw.msg(
'gather-create-new-button-label' ),
+ placeholder: mw.msg( 'gather-add-new-placeholder' ),
subheadingNewCollection: mw.msg( 'gather-add-to-new' ),
subheading: mw.msg( 'gather-add-to-existing' ),
collections: []
diff --git a/resources/ext.gather.watchstar/content.hogan
b/resources/ext.gather.watchstar/content.hogan
index dd8b097..6b3b5f9 100644
--- a/resources/ext.gather.watchstar/content.hogan
+++ b/resources/ext.gather.watchstar/content.hogan
@@ -13,7 +13,8 @@
</div>
<h3>{{subheadingNewCollection}}</h3>
<form>
- <input class="mw-ui-input mw-ui-input-inline"><button
class='mw-ui-button mw-ui-constructive' disabled>{{createButtonLabel}}</button>
+ <input class="mw-ui-input mw-ui-input-inline"
+ placeholder="{{placeholder}}"><button class='mw-ui-button
mw-ui-constructive' disabled>{{createButtonLabel}}</button>
</form>
<hr/>
<h3>{{subheading}}</h3>
diff --git a/resources/ext.gather.watchstar/contentOverlay.less
b/resources/ext.gather.watchstar/contentOverlay.less
index df2d23a..b7517b1 100644
--- a/resources/ext.gather.watchstar/contentOverlay.less
+++ b/resources/ext.gather.watchstar/contentOverlay.less
@@ -83,6 +83,8 @@
// Limit size for small resolutions so fits in one line
form {
+ text-align: center;
+
input {
max-width: 150px;
}
--
To view, visit https://gerrit.wikimedia.org/r/197795
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I79330e8f41ea55798a2ea510432491a2e613b02e
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/Gather
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: Jhernandez <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
