Filippo Giunchedi has submitted this change and it was merged. Change subject: Make deploy2graphite use mw-deployment-vars.sh ......................................................................
Make deploy2graphite use mw-deployment-vars.sh deploy2graphite was switched to use /etc/profile.d/mediawiki.sh in Ibaa28d8, but that config file does not declare the $MW_STATSD_HOST and $MW_STATSD_PORT variables needed by the script. /usr/local/lib/mw-deployment-vars.sh is still provisioned by ::scap::scripts and includes the needed variables. Bug: T1387 Change-Id: I58eeace9619ba1771e6b0cdc4bd748121ad59c2c --- M modules/scap/files/deploy2graphite 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Filippo Giunchedi: Verified; Looks good to me, approved diff --git a/modules/scap/files/deploy2graphite b/modules/scap/files/deploy2graphite index 7f6b259..4dead4a 100755 --- a/modules/scap/files/deploy2graphite +++ b/modules/scap/files/deploy2graphite @@ -1,6 +1,6 @@ #! /bin/bash -. /etc/profile.d/mediawiki.sh +. /usr/local/lib/mw-deployment-vars.sh usage() { echo "Usage: $0 deploy_type [deploy_duration_seconds]" -- To view, visit https://gerrit.wikimedia.org/r/183568 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I58eeace9619ba1771e6b0cdc4bd748121ad59c2c Gerrit-PatchSet: 4 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Reedy <re...@wikimedia.org> Gerrit-Reviewer: BryanDavis <bda...@wikimedia.org> Gerrit-Reviewer: Dzahn <dz...@wikimedia.org> Gerrit-Reviewer: Filippo Giunchedi <fgiunch...@wikimedia.org> Gerrit-Reviewer: Ori.livneh <o...@wikimedia.org> Gerrit-Reviewer: Reedy <re...@wikimedia.org> Gerrit-Reviewer: Yuvipanda <yuvipa...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits