jenkins-bot has submitted this change and it was merged.

Change subject: Improve documentation of useLegacyChangesSubscription setting
......................................................................


Improve documentation of useLegacyChangesSubscription setting

It is important to be aware that this setting is in both
client and repo and take care of setting it correctly if
both client + repo are enabled on a wiki.

Change-Id: I870d451bf8cd0b2b152cebdb688867767037a660
---
M client/config/WikibaseClient.default.php
M repo/config/Wikibase.default.php
2 files changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Daniel Kinzler: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/client/config/WikibaseClient.default.php 
b/client/config/WikibaseClient.default.php
index 575d228..db0a674 100644
--- a/client/config/WikibaseClient.default.php
+++ b/client/config/WikibaseClient.default.php
@@ -53,6 +53,9 @@
                'useLegacyUsageIndex' => false,
 
                // Enable in case wb_changes_subscription does not exist (on 
the repo) or is not yet populated.
+               //
+               // @note: if Wikibase Repo and Client are enabled on the same 
wiki, then this only needs
+               // to be set in the repo or can be set the same in both. (repo 
settings override client settings)
                'useLegacyChangesSubscription' => false,
 
                /**
diff --git a/repo/config/Wikibase.default.php b/repo/config/Wikibase.default.php
index 597c2b0..848be40 100644
--- a/repo/config/Wikibase.default.php
+++ b/repo/config/Wikibase.default.php
@@ -103,6 +103,9 @@
                },
 
                // Enable in case wb_changes_subscription does not exist or is 
not yet populated.
+        //
+               // @note: if Wikibase Repo and Client are enabled on the same 
wiki, then this only needs
+        // to be set in the repo or can be set the same in both. (repo 
settings override client settings)
                'useLegacyChangesSubscription' => false,
 
                'allowEntityImport' => false,

-- 
To view, visit https://gerrit.wikimedia.org/r/198212
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I870d451bf8cd0b2b152cebdb688867767037a660
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: Daniel Kinzler <daniel.kinz...@wikimedia.de>
Gerrit-Reviewer: Hoo man <h...@online.de>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to