Jforrester has uploaded a new change for review.
https://gerrit.wikimedia.org/r/198447
Change subject: Revert "Add directionality classes to window manager"
......................................................................
Revert "Add directionality classes to window manager"
This reverts commit 653638069805990ece6d2422ab2fcbeecd992d92.
We decided to just CSS hide the breakage instead for expediency.
Change-Id: I5dd1eccf37604b77b875ab725c213cb8281ac940
---
M src/ui/ve.ui.WindowManager.js
M src/ui/windowmanagers/ve.ui.SurfaceWindowManager.js
2 files changed, 0 insertions(+), 23 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor
refs/changes/47/198447/1
diff --git a/src/ui/ve.ui.WindowManager.js b/src/ui/ve.ui.WindowManager.js
index 8749da2..a44fa6d 100644
--- a/src/ui/ve.ui.WindowManager.js
+++ b/src/ui/ve.ui.WindowManager.js
@@ -23,9 +23,6 @@
// Properties
this.overlay = config.overlay || null;
-
- this.$element
- .addClass( 've-ui-dir-block-' + this.getDir() );
};
/* Inheritance */
@@ -33,14 +30,6 @@
OO.inheritClass( ve.ui.WindowManager, OO.ui.WindowManager );
/* Methods */
-
-/**
- * Get directionality
- * @return {string} UI directionality
- */
-ve.ui.WindowManager.prototype.getDir = function () {
- return $( 'body' ).css( 'direction' );
-};
/**
* Get overlay for menus.
diff --git a/src/ui/windowmanagers/ve.ui.SurfaceWindowManager.js
b/src/ui/windowmanagers/ve.ui.SurfaceWindowManager.js
index 8c5b7c1..4625da8 100644
--- a/src/ui/windowmanagers/ve.ui.SurfaceWindowManager.js
+++ b/src/ui/windowmanagers/ve.ui.SurfaceWindowManager.js
@@ -32,18 +32,6 @@
/* Methods */
/**
- * Override the window manager's directionality method to get the
- * directionality from the surface. The surface sometimes does not
- * have a directionality set; fallback to direction from the document.
- * @return {string} UI directionality
- */
-ve.ui.SurfaceWindowManager.prototype.getDir = function () {
- return this.surface.getDir() ||
- // Fallback to parent method
- ve.ui.SurfaceWindowManager.super.prototype.getDir.call( this );
-};
-
-/**
* Get surface.
*
* @return {ve.ui.Surface} Surface this belongs to
--
To view, visit https://gerrit.wikimedia.org/r/198447
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5dd1eccf37604b77b875ab725c213cb8281ac940
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: wmf/1.25wmf21
Gerrit-Owner: Jforrester <jforres...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
