jenkins-bot has submitted this change and it was merged. Change subject: Set wgAutoloadAttemptLowercase = true for some AutoLoaderTests ......................................................................
Set wgAutoloadAttemptLowercase = true for some AutoLoaderTests Avoids: 1) AutoLoaderTest::testWrongCaseClass Failed asserting that false is true. 2) AutoLoaderTest::testWrongCaseSerializedClass unserialize() can load classes case-insensitively. Failed asserting that true is false. Change-Id: Ic5c271906fb9b2e27639aa8ecfc04ffe6788d3eb --- M tests/phpunit/structure/AutoLoaderTest.php 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Legoktm: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/phpunit/structure/AutoLoaderTest.php b/tests/phpunit/structure/AutoLoaderTest.php index 681b2d2..cde6547a 100644 --- a/tests/phpunit/structure/AutoLoaderTest.php +++ b/tests/phpunit/structure/AutoLoaderTest.php @@ -130,10 +130,14 @@ } function testWrongCaseClass() { + $this->setMwGlobals( 'wgAutoloadAttemptLowercase', true ); + $this->assertTrue( class_exists( 'testautoLoadedcamlCLASS' ) ); } function testWrongCaseSerializedClass() { + $this->setMwGlobals( 'wgAutoloadAttemptLowercase', true ); + $dummyCereal = 'O:29:"testautoloadedserializedclass":0:{}'; $uncerealized = unserialize( $dummyCereal ); $this->assertFalse( $uncerealized instanceof __PHP_Incomplete_Class, -- To view, visit https://gerrit.wikimedia.org/r/198478 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic5c271906fb9b2e27639aa8ecfc04ffe6788d3eb Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Umherirrender <umherirrender_de...@web.de> Gerrit-Reviewer: Hashar <has...@free.fr> Gerrit-Reviewer: Legoktm <legoktm.wikipe...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits