jenkins-bot has submitted this change and it was merged.

Change subject: Handle MWException in forceSearchIndex.php script
......................................................................


Handle MWException in forceSearchIndex.php script

In addition to MWContentSerializationException, since MWException
can also occur if there is unknown content type for some page
in the database, for example.

In such situation, Cirrus should just skip indexing such page
and report a warning.

Bug: T93575
Change-Id: I450964a57bd36ae315cdd1710e50119f3fe87eea
---
M maintenance/forceSearchIndex.php
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Manybubbles: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/maintenance/forceSearchIndex.php b/maintenance/forceSearchIndex.php
index 3aa5728..999f440 100644
--- a/maintenance/forceSearchIndex.php
+++ b/maintenance/forceSearchIndex.php
@@ -5,7 +5,7 @@
 use \JobQueueGroup;
 use \LinkCache;
 use \Maintenance;
-use \MWContentSerializationException;
+use \MWException;
 use \MWTimestamp;
 use \Title;
 use \WikiPage;
@@ -357,7 +357,7 @@
 
                        try {
                                $content = $page->getContent();
-                       } catch ( MWContentSerializationException $ex ) {
+                       } catch ( MWException $ex ) {
                                wfLogWarning( "Error deserializing content, 
skipping page: $row->page_id\n" );
                                continue;
                        }

-- 
To view, visit https://gerrit.wikimedia.org/r/198704
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I450964a57bd36ae315cdd1710e50119f3fe87eea
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/CirrusSearch
Gerrit-Branch: master
Gerrit-Owner: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: Chad <ch...@wikimedia.org>
Gerrit-Reviewer: Manybubbles <never...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to