Aude has uploaded a new change for review.
https://gerrit.wikimedia.org/r/198724
Change subject: Fix filtering in change dispatcher.
......................................................................
Fix filtering in change dispatcher.
This fixes a bug that causes changes to be dispatched to wikis
to which it is not relevant. The issue was that the return value of
isRelevantChange(), which returns a boolean, was checked with !== null,
which of course is always true, even if the return value was false.
NOTE: If5ea19e29a15 refactors changeDispatcher and adds tests.
Change-Id: Ib6f733fbd84e27784c99a2d1440a35f625215d2b
---
M lib/maintenance/dispatchChanges.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/24/198724/1
diff --git a/lib/maintenance/dispatchChanges.php
b/lib/maintenance/dispatchChanges.php
index f2131d8..96ae2cf 100644
--- a/lib/maintenance/dispatchChanges.php
+++ b/lib/maintenance/dispatchChanges.php
@@ -860,7 +860,7 @@
// The change is relevant if it alters any
sitelinks referring to $siteID,
// or the item currently links to $siteID.
if ( isset( $linkedItems[$itemId] )
- || $this->isRelevantChange( $change,
$siteID ) !== null ) {
+ || $this->isRelevantChange( $change,
$siteID ) ) {
$filteredChanges[] = $change;
$numberOfChangesFound++;
--
To view, visit https://gerrit.wikimedia.org/r/198724
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib6f733fbd84e27784c99a2d1440a35f625215d2b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: wmf/1.25wmf22
Gerrit-Owner: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: Daniel Kinzler <daniel.kinz...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
