jenkins-bot has submitted this change and it was merged.
Change subject: Fix prioritizing sort in dispatchChanges.
......................................................................
Fix prioritizing sort in dispatchChanges.
This fixes a bug that causes the order in which clients are picked
for dispatching to be random, instead of selecting the most lagged
client first.
Backporting this to have more control over the deploy.
Change-Id: If390b4773debdc41889d211934f6c92550b4cfc1
(cherry picked from commit 07fbc59bccdca26a46cdde7ea9f21534052e5abe)
---
M lib/maintenance/dispatchChanges.php
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Aude: Looks good to me, approved
Daniel Kinzler: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/lib/maintenance/dispatchChanges.php
b/lib/maintenance/dispatchChanges.php
index f2131d8..81d896b 100644
--- a/lib/maintenance/dispatchChanges.php
+++ b/lib/maintenance/dispatchChanges.php
@@ -418,9 +418,9 @@
,
__METHOD__,
array(
- 'ORDER BY chd_seen ASC',
+ 'ORDER BY' => 'chd_seen ASC',
'FOR UPDATE',
- 'LIMIT ' . (int)$this->randomness
+ 'LIMIT' => (int)$this->randomness
)
);
--
To view, visit https://gerrit.wikimedia.org/r/199232
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If390b4773debdc41889d211934f6c92550b4cfc1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: wmf/1.25wmf22
Gerrit-Owner: Hoo man <h...@online.de>
Gerrit-Reviewer: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: Daniel Kinzler <daniel.kinz...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
