Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/199537
Change subject: Fix JS exception when tutorial loads
......................................................................
Fix JS exception when tutorial loads
Uncaught TypeError: Cannot read property 'remove' of undefined
Might be related to
bug: 1147115
Change-Id: I76cd5c8956e79145e18e5af9eea6839a85d4f28a
---
M resources/ext.gather.watchstar/init.js
1 file changed, 1 insertion(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Gather
refs/changes/37/199537/1
diff --git a/resources/ext.gather.watchstar/init.js
b/resources/ext.gather.watchstar/init.js
index 2197a2b..5715aff 100644
--- a/resources/ext.gather.watchstar/init.js
+++ b/resources/ext.gather.watchstar/init.js
@@ -7,6 +7,7 @@
settingOverlayWasDismissed = 'gather-has-dismissed-tutorial',
user = M.require( 'user' ),
page = M.getCurrentPage();
+ settings.remove( settingOverlayWasDismissed );
/**
* Determines if collection tutorial should be shown
@@ -67,9 +68,6 @@
overlayDismissed();
} );
actionOverlay.show();
- // Refresh pointer otherwise it is not positioned
- // FIXME: Remove when ContentOverlay is fixed
- actionOverlay.refreshPointerArrow( $star );
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/199537
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I76cd5c8956e79145e18e5af9eea6839a85d4f28a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Gather
Gerrit-Branch: master
Gerrit-Owner: Robmoen <rm...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
