Hashar has submitted this change and it was merged. Change subject: (bug 35204) set wgLanguageCode in unit tests ......................................................................
(bug 35204) set wgLanguageCode in unit tests Setting $wgContLang without changing $wgLanguageCode accordingly is a very bad idea. This caused about 20 exceptions when using LanguageCode set to 'fr' on my installation: "MWException: Error in MediaWikiLangTestCase::setUp(): $wgLanguageCode ('fr') is different from $wgContLang->getCode() (en)" Follow-up of I2987db68 (2b0edc8). Change-Id: I56d3f1bfc78d6a2e40460533524e82f360490206 --- M tests/phpunit/includes/LanguageConverterTest.php M tests/phpunit/includes/RevisionTest.php M tests/phpunit/includes/SampleTest.php M tests/phpunit/includes/TimeAdjustTest.php M tests/phpunit/includes/TitlePermissionTest.php M tests/phpunit/includes/parser/MagicVariableTest.php M tests/phpunit/includes/parser/NewParserTest.php 7 files changed, 20 insertions(+), 9 deletions(-) Approvals: Hashar: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/31816 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I56d3f1bfc78d6a2e40460533524e82f360490206 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: IAlex <ialex.w...@gmail.com> Gerrit-Reviewer: Hashar <has...@free.fr> Gerrit-Reviewer: IAlex <ialex.w...@gmail.com> Gerrit-Reviewer: Siebrand <siebr...@wikimedia.org> Gerrit-Reviewer: Umherirrender <umherirrender_de...@web.de> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits