jenkins-bot has submitted this change and it was merged. Change subject: Replace mb_strtolower with strtolower ......................................................................
Replace mb_strtolower with strtolower Function mb_strtolower is not guaranteed to be present. In this case we are dealing with language codes, which are ASCII, for which there is no need to use multibyte version in the first place. Bug: T55912 Change-Id: I009bab2ff03b22142d35c8be60711266ca3683c1 --- M includes/media/SVG.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Aaron Schulz: Looks good to me, approved Santhosh: Looks good to me, but someone else must approve jenkins-bot: Verified diff --git a/includes/media/SVG.php b/includes/media/SVG.php index 0618f7e..8fdfa47 100644 --- a/includes/media/SVG.php +++ b/includes/media/SVG.php @@ -487,7 +487,7 @@ function makeParamString( $params ) { $lang = ''; if ( isset( $params['lang'] ) && $params['lang'] !== 'en' ) { - $params['lang'] = mb_strtolower( $params['lang'] ); + $params['lang'] = strtolower( $params['lang'] ); $lang = "lang{$params['lang']}-"; } if ( !isset( $params['width'] ) ) { -- To view, visit https://gerrit.wikimedia.org/r/199584 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I009bab2ff03b22142d35c8be60711266ca3683c1 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Nikerabbit <niklas.laxst...@gmail.com> Gerrit-Reviewer: Aaron Schulz <asch...@wikimedia.org> Gerrit-Reviewer: Santhosh <santhosh.thottin...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits