Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/199846
Change subject: Fix misleading $class = false default in Html::infoBox ...................................................................... Fix misleading $class = false default in Html::infoBox I found this because my PHPStorm complains about the type mismatch. I could have changed the @param tag to "string|bool", but when looking at the code, the $class variable is casted to a string anyway and never used as a bool. Change-Id: I3450fa8a898923bbae26830ed3be0017685020d3 --- M includes/Html.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/46/199846/1 diff --git a/includes/Html.php b/includes/Html.php index c172ae0..6bd661f 100644 --- a/includes/Html.php +++ b/includes/Html.php @@ -997,7 +997,7 @@ * * @return string */ - static function infoBox( $text, $icon, $alt, $class = false ) { + static function infoBox( $text, $icon, $alt, $class = '' ) { $s = Html::openElement( 'div', array( 'class' => "mw-infobox $class" ) ); $s .= Html::openElement( 'div', array( 'class' => 'mw-infobox-left' ) ) . -- To view, visit https://gerrit.wikimedia.org/r/199846 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3450fa8a898923bbae26830ed3be0017685020d3 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits