jenkins-bot has submitted this change and it was merged. Change subject: Make wfWarn name the caller in Http::get ......................................................................
Make wfWarn name the caller in Http::get The warning is useless as of now, unless you have stracktraces. Bug: T91764 Change-Id: I8fcae49f3943ab2f6d13519c5f8d370ed147b185 --- M includes/HttpFunctions.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Santhosh: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/HttpFunctions.php b/includes/HttpFunctions.php index 36e06b5..8e05f59 100644 --- a/includes/HttpFunctions.php +++ b/includes/HttpFunctions.php @@ -96,7 +96,7 @@ if ( isset( $args[1] ) && ( is_string( $args[1] ) || is_numeric( $args[1] ) ) ) { // Second was used to be the timeout // And third parameter used to be $options - wfWarn( "Second parameter should not be a timeout." ); + wfWarn( "Second parameter should not be a timeout.", 2 ); $options = isset( $args[2] ) && is_array( $args[2] ) ? $args[2] : array(); $options['timeout'] = $args[1]; -- To view, visit https://gerrit.wikimedia.org/r/199850 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8fcae49f3943ab2f6d13519c5f8d370ed147b185 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Nikerabbit <niklas.laxst...@gmail.com> Gerrit-Reviewer: Legoktm <legoktm.wikipe...@gmail.com> Gerrit-Reviewer: Santhosh <santhosh.thottin...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits