Santhosh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/199860
Change subject: Introduce common widget style LESS file
......................................................................
Introduce common widget style LESS file
* Add widgets/common/ext.cx.common.less as the top level common
styling for CX
* Abstract the Grid system in it
This is part of common UI widgets refactoring.
Change-Id: I51dfe65f1f23f56845c0ea3051ba6152bf61c80b
---
M modules/base/styles/ext.cx.feedback.less
M modules/dashboard/styles/ext.cx.dashboard.less
M modules/dashboard/styles/ext.cx.magnuslink.less
M modules/dashboard/styles/ext.cx.translationlist.less
M modules/entrypoint/styles/ext.cx.entrypoint.less
M modules/entrypoint/styles/ext.cx.redlink.less
M modules/header/styles/ext.cx.header.less
M modules/publish/styles/ext.cx.publish.dialog.less
M modules/publish/styles/ext.cx.publish.less
M modules/source/styles/ext.cx.source.less
M modules/source/styles/ext.cx.source.selector.less
M modules/stats/styles/ext.cx.stats.less
M modules/tools/styles/ext.cx.progressbar.less
M modules/tools/styles/ext.cx.tools.card.less
M modules/tools/styles/ext.cx.tools.categories.less
M modules/tools/styles/ext.cx.tools.dictionary.less
M modules/tools/styles/ext.cx.tools.formatter.less
M modules/tools/styles/ext.cx.tools.instructions.less
M modules/tools/styles/ext.cx.tools.less
M modules/tools/styles/ext.cx.tools.link.less
M modules/tools/styles/ext.cx.tools.manager.less
M modules/tools/styles/ext.cx.tools.mt.less
M modules/tools/styles/ext.cx.tools.mtabuse.less
M modules/tools/styles/ext.cx.tools.reference.less
M modules/translation/styles/ext.cx.translation.conflict.less
M modules/translation/styles/ext.cx.translation.less
M modules/translationview/styles/ext.cx.translationview.less
R modules/widgets/common/grid/agora-grid.less
R modules/widgets/common/grid/grid-core.less
R modules/widgets/common/grid/grid-responsive.less
R modules/widgets/common/grid/grid-settings.less
31 files changed, 29 insertions(+), 64 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation
refs/changes/60/199860/1
diff --git a/modules/base/styles/ext.cx.feedback.less
b/modules/base/styles/ext.cx.feedback.less
index c54bf9e..ca3d46c 100644
--- a/modules/base/styles/ext.cx.feedback.less
+++ b/modules/base/styles/ext.cx.feedback.less
@@ -1,4 +1,4 @@
-@import "../../base/styles/grid/agora-grid";
+@import "../../widgets/common/ext.cx.common";
@import "mediawiki.mixins";
.cx-feedback {
diff --git a/modules/dashboard/styles/ext.cx.dashboard.less
b/modules/dashboard/styles/ext.cx.dashboard.less
index 8e1c51b..070511d 100644
--- a/modules/dashboard/styles/ext.cx.dashboard.less
+++ b/modules/dashboard/styles/ext.cx.dashboard.less
@@ -1,11 +1,4 @@
-@import "../../base/styles/grid/agora-grid";
-@import "mediawiki.mixins";
-
-@gray-darker: #252525;
-@gray-dark: #565656;
-@gray: #C9C9C9;
-@gray-light: #f0f0f0;
-@gray-lighter: #fbfbfb;
+@import "../../widgets/common/ext.cx.common";
h2 {
color: @gray-darker;
@@ -38,14 +31,6 @@
.cx-feedback {
right: 10px;
}
-}
-
-.cx-widget {
- .mw-ui-grid;
- color: @gray-darker;
- background: white;
- padding-bottom: 50px;
- font-size: medium;
}
// Do not display the header bar containing the link to dashboard in dashboard
page.
diff --git a/modules/dashboard/styles/ext.cx.magnuslink.less
b/modules/dashboard/styles/ext.cx.magnuslink.less
index f521641..78dc0b5 100644
--- a/modules/dashboard/styles/ext.cx.magnuslink.less
+++ b/modules/dashboard/styles/ext.cx.magnuslink.less
@@ -1,5 +1,4 @@
-@import "../../base/styles/grid/agora-grid";
-@import "mediawiki.mixins";
+@import "../../widgets/common/ext.cx.common";
.cx-magnus-link {
.mw-ui-item;
diff --git a/modules/dashboard/styles/ext.cx.translationlist.less
b/modules/dashboard/styles/ext.cx.translationlist.less
index 5683834..b07ec04 100644
--- a/modules/dashboard/styles/ext.cx.translationlist.less
+++ b/modules/dashboard/styles/ext.cx.translationlist.less
@@ -1,4 +1,4 @@
-@import "../../base/styles/grid/agora-grid";
+@import "../../widgets/common/ext.cx.common";
@import "mediawiki.mixins";
.cx-translationlist {
diff --git a/modules/entrypoint/styles/ext.cx.entrypoint.less
b/modules/entrypoint/styles/ext.cx.entrypoint.less
index 8b5aae9..c2cfdad 100644
--- a/modules/entrypoint/styles/ext.cx.entrypoint.less
+++ b/modules/entrypoint/styles/ext.cx.entrypoint.less
@@ -1,4 +1,4 @@
-@import "../../base/styles/grid/agora-grid";
+@import "../../widgets/common/ext.cx.common";
@import "mediawiki.mixins";
.cx-entrypoint-dialog {
@@ -80,4 +80,4 @@
font-size: 12px;
color: #777;
border-top: 1px solid #f5f5f5;
-}
\ No newline at end of file
+}
diff --git a/modules/entrypoint/styles/ext.cx.redlink.less
b/modules/entrypoint/styles/ext.cx.redlink.less
index 932cae3..0d78924 100644
--- a/modules/entrypoint/styles/ext.cx.redlink.less
+++ b/modules/entrypoint/styles/ext.cx.redlink.less
@@ -1,5 +1,3 @@
-@import "../../base/styles/grid/agora-grid";
-
/* Very specific selector to override core's nav bar link style */
div#mw-panel div.portal div.body ul li.cx-new-interlanguage-link a.new {
color: #BA0000;
diff --git a/modules/header/styles/ext.cx.header.less
b/modules/header/styles/ext.cx.header.less
index e0e6751..08b752e 100644
--- a/modules/header/styles/ext.cx.header.less
+++ b/modules/header/styles/ext.cx.header.less
@@ -1,4 +1,4 @@
-@import "../../base/styles/grid/agora-grid";
+@import "../../widgets/common/ext.cx.common";
@import "mediawiki.mixins";
.cx-header {
diff --git a/modules/publish/styles/ext.cx.publish.dialog.less
b/modules/publish/styles/ext.cx.publish.dialog.less
index b0b7423..7c4d1b4 100644
--- a/modules/publish/styles/ext.cx.publish.dialog.less
+++ b/modules/publish/styles/ext.cx.publish.dialog.less
@@ -1,4 +1,4 @@
-@import "../../base/styles/grid/agora-grid";
+@import "../../widgets/common/ext.cx.common";
@import "mediawiki.mixins";
.cx-publishing-dialog {
diff --git a/modules/publish/styles/ext.cx.publish.less
b/modules/publish/styles/ext.cx.publish.less
index fc8dfd1..293e6b9 100644
--- a/modules/publish/styles/ext.cx.publish.less
+++ b/modules/publish/styles/ext.cx.publish.less
@@ -1,4 +1,4 @@
-@import "../../base/styles/grid/agora-grid";
+@import "../../widgets/common/ext.cx.common";
.cx-publish-captcha-form {
position: absolute;
diff --git a/modules/source/styles/ext.cx.source.less
b/modules/source/styles/ext.cx.source.less
index 36229d2..551bb62 100644
--- a/modules/source/styles/ext.cx.source.less
+++ b/modules/source/styles/ext.cx.source.less
@@ -1,4 +1,4 @@
-@import "../../base/styles/grid/agora-grid";
+@import "../../widgets/common/ext.cx.common";
@text-highlight-color: #FEFCE0;
@link-highlight-color: #BDD4FF;
diff --git a/modules/source/styles/ext.cx.source.selector.less
b/modules/source/styles/ext.cx.source.selector.less
index ff02a0e..0436312 100644
--- a/modules/source/styles/ext.cx.source.selector.less
+++ b/modules/source/styles/ext.cx.source.selector.less
@@ -1,4 +1,4 @@
-@import "../../base/styles/grid/agora-grid";
+@import "../../widgets/common/ext.cx.common";
@import "mediawiki.mixins";
.cx-sourceselector-dialog {
diff --git a/modules/stats/styles/ext.cx.stats.less
b/modules/stats/styles/ext.cx.stats.less
index b304b52..6aa1ab7 100644
--- a/modules/stats/styles/ext.cx.stats.less
+++ b/modules/stats/styles/ext.cx.stats.less
@@ -1,4 +1,4 @@
-@import "../../base/styles/grid/agora-grid";
+@import "../../widgets/common/ext.cx.common";
.cx-stats {
border-collapse: collapse;
diff --git a/modules/tools/styles/ext.cx.progressbar.less
b/modules/tools/styles/ext.cx.progressbar.less
index dbeb660..f5f84de 100644
--- a/modules/tools/styles/ext.cx.progressbar.less
+++ b/modules/tools/styles/ext.cx.progressbar.less
@@ -1,4 +1,4 @@
-@import "../../base/styles/grid/agora-grid";
+@import "../../widgets/common/ext.cx.common";
.cx-header__progressbar {
.mw-ui-one-whole;
diff --git a/modules/tools/styles/ext.cx.tools.card.less
b/modules/tools/styles/ext.cx.tools.card.less
index 3feb886..2281b85 100644
--- a/modules/tools/styles/ext.cx.tools.card.less
+++ b/modules/tools/styles/ext.cx.tools.card.less
@@ -1,4 +1,4 @@
-@import "../../base/styles/grid/agora-grid";
+@import "../../widgets/common/ext.cx.common";
.card {
background: #FFFFFF;
diff --git a/modules/tools/styles/ext.cx.tools.categories.less
b/modules/tools/styles/ext.cx.tools.categories.less
index 28846f8..2bde2bf 100644
--- a/modules/tools/styles/ext.cx.tools.categories.less
+++ b/modules/tools/styles/ext.cx.tools.categories.less
@@ -1,4 +1,4 @@
-@import "../../base/styles/grid/agora-grid";
+@import "../../widgets/common/ext.cx.common";
@import "mediawiki.mixins";
@text-highlight-color: #FEFCE0;
diff --git a/modules/tools/styles/ext.cx.tools.dictionary.less
b/modules/tools/styles/ext.cx.tools.dictionary.less
index a6bd169..4d9a0e2 100644
--- a/modules/tools/styles/ext.cx.tools.dictionary.less
+++ b/modules/tools/styles/ext.cx.tools.dictionary.less
@@ -1,4 +1,4 @@
-@import "../../base/styles/grid/agora-grid";
+@import "../../widgets/common/ext.cx.common";
.card.dictionary {
animation-name: card-show-animation;
diff --git a/modules/tools/styles/ext.cx.tools.formatter.less
b/modules/tools/styles/ext.cx.tools.formatter.less
index e003708..fa1e5c9 100644
--- a/modules/tools/styles/ext.cx.tools.formatter.less
+++ b/modules/tools/styles/ext.cx.tools.formatter.less
@@ -1,4 +1,4 @@
-@import "../../base/styles/grid/agora-grid";
+@import "../../widgets/common/ext.cx.common";
@import "mediawiki.mixins";
.card__format {
diff --git a/modules/tools/styles/ext.cx.tools.instructions.less
b/modules/tools/styles/ext.cx.tools.instructions.less
index fb91872..b45c376 100644
--- a/modules/tools/styles/ext.cx.tools.instructions.less
+++ b/modules/tools/styles/ext.cx.tools.instructions.less
@@ -1,4 +1,4 @@
-@import "../../base/styles/grid/agora-grid";
+@import "../../widgets/common/ext.cx.common";
.card.instructions {
animation-name: card-show-animation;
diff --git a/modules/tools/styles/ext.cx.tools.less
b/modules/tools/styles/ext.cx.tools.less
index 7f39295..e044684 100644
--- a/modules/tools/styles/ext.cx.tools.less
+++ b/modules/tools/styles/ext.cx.tools.less
@@ -1,4 +1,4 @@
-@import "../../base/styles/grid/agora-grid";
+@import "../../widgets/common/ext.cx.common";
@import "mediawiki.mixins";
.cx-card--search {
diff --git a/modules/tools/styles/ext.cx.tools.link.less
b/modules/tools/styles/ext.cx.tools.link.less
index d9fceae..06c8b4f 100644
--- a/modules/tools/styles/ext.cx.tools.link.less
+++ b/modules/tools/styles/ext.cx.tools.link.less
@@ -1,4 +1,4 @@
-@import "../../base/styles/grid/agora-grid";
+@import "../../widgets/common/ext.cx.common";
@import "mediawiki.mixins";
.cards.link {
diff --git a/modules/tools/styles/ext.cx.tools.manager.less
b/modules/tools/styles/ext.cx.tools.manager.less
index 0cfa7b4..eea1203 100644
--- a/modules/tools/styles/ext.cx.tools.manager.less
+++ b/modules/tools/styles/ext.cx.tools.manager.less
@@ -1,4 +1,4 @@
-@import "../../base/styles/grid/agora-grid";
+@import "../../widgets/common/ext.cx.common";
.card__section {
.mw-ui-grid;
diff --git a/modules/tools/styles/ext.cx.tools.mt.less
b/modules/tools/styles/ext.cx.tools.mt.less
index f586ca6..1f5fda9 100644
--- a/modules/tools/styles/ext.cx.tools.mt.less
+++ b/modules/tools/styles/ext.cx.tools.mt.less
@@ -1,4 +1,4 @@
-@import "../../base/styles/grid/agora-grid";
+@import "../../widgets/common/ext.cx.common";
@import "mediawiki.mixins";
.card.mt {
diff --git a/modules/tools/styles/ext.cx.tools.mtabuse.less
b/modules/tools/styles/ext.cx.tools.mtabuse.less
index b9d42cc..a454478 100644
--- a/modules/tools/styles/ext.cx.tools.mtabuse.less
+++ b/modules/tools/styles/ext.cx.tools.mtabuse.less
@@ -1,4 +1,4 @@
-@import "../../base/styles/grid/agora-grid";
+@import "../../widgets/common/ext.cx.common";
@import "mediawiki.mixins";
.card.mtabuse {
diff --git a/modules/tools/styles/ext.cx.tools.reference.less
b/modules/tools/styles/ext.cx.tools.reference.less
index 2a83e76..beaf046 100644
--- a/modules/tools/styles/ext.cx.tools.reference.less
+++ b/modules/tools/styles/ext.cx.tools.reference.less
@@ -1,4 +1,4 @@
-@import "../../base/styles/grid/agora-grid";
+@import "../../widgets/common/ext.cx.common";
@import "mediawiki.mixins";
.card.reference {
diff --git a/modules/translation/styles/ext.cx.translation.conflict.less
b/modules/translation/styles/ext.cx.translation.conflict.less
index d1003fd..9a7a615 100644
--- a/modules/translation/styles/ext.cx.translation.conflict.less
+++ b/modules/translation/styles/ext.cx.translation.conflict.less
@@ -1,4 +1,5 @@
-@import "../../base/styles/grid/agora-grid";
+@import "../../widgets/common/ext.cx.common";
+
.cx-conflict {
.mw-ui-item;
.mw-ui-one-whole;
@@ -13,4 +14,4 @@
.cx-create-new-translation {
float: right;
}
-}
\ No newline at end of file
+}
diff --git a/modules/translation/styles/ext.cx.translation.less
b/modules/translation/styles/ext.cx.translation.less
index 92531c7..35c2417 100644
--- a/modules/translation/styles/ext.cx.translation.less
+++ b/modules/translation/styles/ext.cx.translation.less
@@ -1,4 +1,4 @@
-@import "../../base/styles/grid/agora-grid";
+@import "../../widgets/common/ext.cx.common";
@text-highlight-color: #FEFCE0;
@link-highlight-color: #BDD4FF;
diff --git a/modules/translationview/styles/ext.cx.translationview.less
b/modules/translationview/styles/ext.cx.translationview.less
index ff642b4..5ce34f8 100644
--- a/modules/translationview/styles/ext.cx.translationview.less
+++ b/modules/translationview/styles/ext.cx.translationview.less
@@ -1,10 +1,4 @@
-@import "../../base/styles/grid/agora-grid";
-
-@gray-darker: #252525;
-@gray-dark: #565656;
-@gray: #C9C9C9;
-@gray-light: #f0f0f0;
-@gray-lighter: #fbfbfb;
+@import "../../widgets/common/ext.cx.common";
h2 {
color: @gray-darker;
@@ -14,18 +8,6 @@
font-size: 2.2em;
font-family: 'Linux Libertine', Georgia, Times, serif;
margin-bottom: 10px;
-}
-
-/**
- * Container for the translation widget
- */
-.cx-widget {
- .mw-ui-grid;
-
- color: @gray-darker;
- background: white;
- padding-bottom: 50px;
- font-size: medium;
}
.cx-widget__header {
diff --git a/modules/base/styles/grid/agora-grid.less
b/modules/widgets/common/grid/agora-grid.less
similarity index 100%
rename from modules/base/styles/grid/agora-grid.less
rename to modules/widgets/common/grid/agora-grid.less
diff --git a/modules/base/styles/grid/grid-core.less
b/modules/widgets/common/grid/grid-core.less
similarity index 100%
rename from modules/base/styles/grid/grid-core.less
rename to modules/widgets/common/grid/grid-core.less
diff --git a/modules/base/styles/grid/grid-responsive.less
b/modules/widgets/common/grid/grid-responsive.less
similarity index 100%
rename from modules/base/styles/grid/grid-responsive.less
rename to modules/widgets/common/grid/grid-responsive.less
diff --git a/modules/base/styles/grid/grid-settings.less
b/modules/widgets/common/grid/grid-settings.less
similarity index 100%
rename from modules/base/styles/grid/grid-settings.less
rename to modules/widgets/common/grid/grid-settings.less
--
To view, visit https://gerrit.wikimedia.org/r/199860
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I51dfe65f1f23f56845c0ea3051ba6152bf61c80b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Santhosh <santhosh.thottin...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
