jenkins-bot has submitted this change and it was merged.
Change subject: Removed stale FIXME + comment typo fix.
......................................................................
Removed stale FIXME + comment typo fix.
Change-Id: Ifc8a60fcf4975fc9a95f47d86d5582a0a971bb9c
---
M lib/ext.core.AttributeExpander.js
M lib/ext.core.LinkHandler.js
2 files changed, 1 insertion(+), 5 deletions(-)
Approvals:
Arlolra: Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/ext.core.AttributeExpander.js
b/lib/ext.core.AttributeExpander.js
index cf89a72..c146705 100644
--- a/lib/ext.core.AttributeExpander.js
+++ b/lib/ext.core.AttributeExpander.js
@@ -32,7 +32,7 @@
// SSS FIXME: We cannot support this usage for <*include*> directives
currently
// since they don't go through template encapsulation and don't have a
data-mw
// format with "wt" and "transclusion" parts that we can use to just
track bits
- // of wikiext that don't have a DOM representation.
+ // of wikitext that don't have a DOM representation.
//
// So, for now, we just suppress all newlines contained within these
directives.
//
diff --git a/lib/ext.core.LinkHandler.js b/lib/ext.core.LinkHandler.js
index da17990..5d80ce4 100644
--- a/lib/ext.core.LinkHandler.js
+++ b/lib/ext.core.LinkHandler.js
@@ -1151,14 +1151,10 @@
/**
* Render a file. This can be an image, a sound, a PDF etc.
- *
- * FIXME: move all these nested functions out so that the data flow becomes
- * clearer.
*/
WikiLinkHandler.prototype.renderFile = function (token, frame, cb, target) {
var fileName = target.href,
title = target.title;
-
// First check if we have a cached copy of this image expansion, and
// avoid any further processing if we have a cache hit.
--
To view, visit https://gerrit.wikimedia.org/r/199739
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifc8a60fcf4975fc9a95f47d86d5582a0a971bb9c
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Subramanya Sastry <ssas...@wikimedia.org>
Gerrit-Reviewer: Arlolra <abrea...@wikimedia.org>
Gerrit-Reviewer: Cscott <canan...@wikimedia.org>
Gerrit-Reviewer: Marcoil <marc...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
