Legoktm has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/200108

Change subject: Don't throw a plain \Exception
......................................................................

Don't throw a plain \Exception

Change-Id: I681387914c62d6cfa8048b5681825d4b9c0783cc
---
M includes/specials/SpecialGather.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Gather 
refs/changes/08/200108/1

diff --git a/includes/specials/SpecialGather.php 
b/includes/specials/SpecialGather.php
index 4b8b3dd..ce216c6 100644
--- a/includes/specials/SpecialGather.php
+++ b/includes/specials/SpecialGather.php
@@ -12,7 +12,7 @@
 use \UsageException;
 use \DerivativeRequest;
 use \ApiMain;
-use \Exception;
+use \InvalidArgumentException;
 
 /**
  * Render a collection of articles.
@@ -110,7 +110,7 @@
         */
        public function renderUserCollection( User $user, $id ) {
                if ( !is_int( $id ) ) {
-                       throw new Exception( __METHOD__ . ' requires the second 
parameter to be an integer, '
+                       throw new InvalidArgumentException( __METHOD__ . ' 
requires the second parameter to be an integer, '
                                . gettype( $id ) . ' given.' );
                }
                $collection = models\Collection::newFromApi( $id, $user );

-- 
To view, visit https://gerrit.wikimedia.org/r/200108
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I681387914c62d6cfa8048b5681825d4b9c0783cc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Gather
Gerrit-Branch: master
Gerrit-Owner: Legoktm <legoktm.wikipe...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to