Mooeypoo has uploaded a new change for review.
https://gerrit.wikimedia.org/r/200212
Change subject: Verify welcome dialog exists before trying to close it
......................................................................
Verify welcome dialog exists before trying to close it
When deactivating, verify first that the welcome dialog was
initialized before calling 'close' on it.
Change-Id: Ife98b396f3d8641e2bd313c549fe867bcd84db9b
---
M modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/12/200212/1
diff --git a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
index 72144e6..078d506 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
@@ -342,7 +342,9 @@
}
// Just in case this wasn't closed before
- this.welcomeDialog.close();
+ if ( this.welcomeDialog ) {
+ this.welcomeDialog.close();
+ }
if ( noDialog || this.activating || !this.edited ) {
this.cancel( trackMechanism );
--
To view, visit https://gerrit.wikimedia.org/r/200212
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ife98b396f3d8641e2bd313c549fe867bcd84db9b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo <mor...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
