[MediaWiki-commits] [Gerrit] Mock error event firing in mw.loader test - change (mediawiki/core)

[Code Review]

Gergő Tisza has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/200292

Change subject: Mock error event firing in mw.loader test
......................................................................

Mock error event firing in mw.loader test

Change-Id: I5528f5f91a7452ff05b7493466467cf026f59c40
---
M tests/qunit/suites/resources/mediawiki/mediawiki.test.js
1 file changed, 4 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/92/200292/1

diff --git a/tests/qunit/suites/resources/mediawiki/mediawiki.test.js 
b/tests/qunit/suites/resources/mediawiki/mediawiki.test.js
index 18db7f1..cf36ea8 100644
--- a/tests/qunit/suites/resources/mediawiki/mediawiki.test.js
+++ b/tests/qunit/suites/resources/mediawiki/mediawiki.test.js
@@ -692,10 +692,9 @@
                } );
        } );
 
-       QUnit.test( 'mw.loader erroneous indirect dependency', 5, function ( 
assert ) {
-               // Keep "Error: expected" out of build log
-               var log = this.sandbox.stub( window.console || {}, 'log' ),
-                       error = this.sandbox.stub( window.console || {}, 
'error' );
+       QUnit.test( 'mw.loader erroneous indirect dependency', 4, function ( 
assert ) {
+               // don't emit an error event
+               this.sandbox.stub( mw, 'track' );
 
                mw.loader.register( [
                        ['test.module1', '0'],
@@ -709,8 +708,7 @@
                assert.strictEqual( mw.loader.getState( 'test.module2' ), 
'error', 'Expected "error" state for test.module2' );
                assert.strictEqual( mw.loader.getState( 'test.module3' ), 
'error', 'Expected "error" state for test.module3' );
 
-               assert.strictEqual( log.callCount, 1 );
-               assert.strictEqual( error.callCount, 1 );
+               assert.strictEqual( mw.track.callCount, 1 );
        } );
 
        QUnit.test( 'mw.loader out-of-order implementation', 9, function ( 
assert ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/200292
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5528f5f91a7452ff05b7493466467cf026f59c40
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gergő Tisza <gti...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits