jenkins-bot has submitted this change and it was merged. Change subject: Always run sanitize, even with no import rules ......................................................................
Always run sanitize, even with no import rules Sanitize is not completely inert when importRules is null (removes empty content nodes). Change-Id: Id4ddae84ce440e09b401763a4cea8e299401d16e --- M src/ce/ve.ce.Surface.js 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Catrope: Looks good to me, approved Jforrester: Looks good to me, approved jenkins-bot: Verified diff --git a/src/ce/ve.ce.Surface.js b/src/ce/ve.ce.Surface.js index 8ac6664..55ee6b8 100644 --- a/src/ce/ve.ce.Surface.js +++ b/src/ce/ve.ce.Surface.js @@ -1994,7 +1994,7 @@ if ( importRules.all ) { data.sanitize( importRules.all ); } - } else if ( importRules.all || this.pasteSpecial ) { + } else { data.sanitize( importRules.all || {}, this.pasteSpecial ); } data.remapInternalListKeys( this.model.getDocument().getInternalList() ); -- To view, visit https://gerrit.wikimedia.org/r/200303 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id4ddae84ce440e09b401763a4cea8e299401d16e Gerrit-PatchSet: 3 Gerrit-Project: VisualEditor/VisualEditor Gerrit-Branch: master Gerrit-Owner: Esanders <esand...@wikimedia.org> Gerrit-Reviewer: Catrope <roan.katt...@gmail.com> Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits