Aude has uploaded a new change for review.
https://gerrit.wikimedia.org/r/200642
Change subject: dispatchChanges: Don't use FOR UPDATE for selecting a client
......................................................................
dispatchChanges: Don't use FOR UPDATE for selecting a client
Also make the randomness parameter actually work and increase the
default value. In production the value should be even higher.
Change-Id: Ie7d68953be5c680c964d12a4943d72886407d9ad
---
M lib/maintenance/dispatchChanges.php
1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/42/200642/1
diff --git a/lib/maintenance/dispatchChanges.php
b/lib/maintenance/dispatchChanges.php
index f2131d8..c014708 100644
--- a/lib/maintenance/dispatchChanges.php
+++ b/lib/maintenance/dispatchChanges.php
@@ -98,7 +98,7 @@
* causes a completely random selection of the target,
regardless of when it
* was last selected for dispatch.
*/
- protected $randomness = 5;
+ protected $randomness = 10;
/**
* @var bool: whether output should be version.
@@ -119,7 +119,7 @@
$this->addOption( 'lock-grace-interval', "Seconds after wich to
probe for orphaned locks. "
. "Default: 60", false, true );
$this->addOption( 'randomness', "Number of least current target
wikis to pick from at random. "
- . "Default: 5.", false, true );
+ . "Default: 10.", false, true );
$this->addOption( 'max-passes', "The number of passes to
perform. "
. "Default: 1 if --max-time is not set,
infinite if it is.", false, true );
$this->addOption( 'max-time', "The number of seconds to run
before exiting, "
@@ -146,6 +146,7 @@
$this->delay = intval( $this->getOption( 'idle-delay', 10 ) );
$this->dispatchInterval = intval( $this->getOption(
'dispatch-interval', 60 ) );
$this->lockGraceInterval = intval( $this->getOption(
'lock-grace-interval', 60 ) );
+ $this->randomness = intval( $this->getOption( 'randomness',
$this->randomness ) );
$this->verbose = $this->getOption( 'verbose', false );
@@ -418,9 +419,8 @@
,
__METHOD__,
array(
- 'ORDER BY chd_seen ASC',
- 'FOR UPDATE',
- 'LIMIT ' . (int)$this->randomness
+ 'ORDER BY' => 'chd_seen ASC',
+ 'LIMIT' => (int)$this->randomness
)
);
--
To view, visit https://gerrit.wikimedia.org/r/200642
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie7d68953be5c680c964d12a4943d72886407d9ad
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: wmf/1.25wmf22
Gerrit-Owner: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: Hoo man <h...@online.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
