jenkins-bot has submitted this change and it was merged.
Change subject: Always do an action if schema.log() finished
......................................................................
Always do an action if schema.log() finished
Not only if it was successful.
Change-Id: Ie9b97ac1d6c8fb3cfcf708c92e225e17a5bccdd9
---
M resources/ext.gather.collection.delete/CollectionDeleteOverlay.js
M resources/ext.gather.collection.editor/CollectionEditOverlay.js
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/ext.gather.collection.delete/CollectionDeleteOverlay.js
b/resources/ext.gather.collection.delete/CollectionDeleteOverlay.js
index 4e43912..1ce42d4 100644
--- a/resources/ext.gather.collection.delete/CollectionDeleteOverlay.js
+++ b/resources/ext.gather.collection.delete/CollectionDeleteOverlay.js
@@ -65,7 +65,7 @@
schema.log( {
eventName: 'delete-collection'
- } ).done( function () {
+ } ).always( function () {
// Go to the collections list page as
collection will no longer exist
window.location.href = mw.util.getUrl(
'Special:Gather' );
} );
diff --git a/resources/ext.gather.collection.editor/CollectionEditOverlay.js
b/resources/ext.gather.collection.editor/CollectionEditOverlay.js
index e95548b..482f6da 100644
--- a/resources/ext.gather.collection.editor/CollectionEditOverlay.js
+++ b/resources/ext.gather.collection.editor/CollectionEditOverlay.js
@@ -69,7 +69,7 @@
// JavaScript state.
schema.log( {
eventName: 'edit-collection'
- } ).done( function () {
+ } ).always( function () {
router.navigate( '/' );
window.location.reload();
} );
--
To view, visit https://gerrit.wikimedia.org/r/200749
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie9b97ac1d6c8fb3cfcf708c92e225e17a5bccdd9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Gather
Gerrit-Branch: master
Gerrit-Owner: Florianschmidtwelzow <florian.schmidt.wel...@t-online.de>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
