Tpt has uploaded a new change for review.
https://gerrit.wikimedia.org/r/200870
Change subject: Makes Special:IndexPages output valid HTML 5
......................................................................
Makes Special:IndexPages output valid HTML 5
Bug: T76284
Change-Id: Ifdb772e6b9990c42a58b80eeb1eaf494d034c091
---
M SpecialProofreadPages.php
M modules/article/ext.proofreadpage.article.css
M modules/ext.proofreadpage.base.css
3 files changed, 27 insertions(+), 31 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ProofreadPage
refs/changes/70/200870/1
diff --git a/SpecialProofreadPages.php b/SpecialProofreadPages.php
index 892b9f4..41d95e5 100644
--- a/SpecialProofreadPages.php
+++ b/SpecialProofreadPages.php
@@ -198,29 +198,21 @@
$q3 = $result->pr_q3;
$q4 = $result->pr_q4;
$num_void = $size-$q1-$q2-$q3-$q4-$q0;
- $void_cell = $num_void ? "<td align=center
style='border-style:dotted;background:#ffffff;border-width:1px;'
width=\"{$num_void}\"></td>" : '';
+ $void_cell = $num_void ? '<td class="qualitye" style="width:' .
$num_void . 'px;"></td>' : '';
+ $qualityOutput = '<table class="pr_quality" style="display:
inline-block; height: 0.6em;">
+<tr>
+<td class="quality4" style="width:' . $q4 . 'px;"></td>
+<td class="quality3" style="width:' . $q3 . 'px;"></td>
+<td class="quality2" style="width:' . $q2 . 'px;"></td>
+<td class="quality1" style="width:' . $q1 . 'px;"></td>
+<td class="quality0" style="width:' . $q0 . 'px;"></td>
+' . $void_cell . '
+</tr>
+</table>';
- $lang = $this->getLanguage();
- $dirmark = $lang->getDirMark();
+ $dirmark = $this->getLanguage()->getDirMark();
$pages = $this->msg( 'proofreadpage_pages', $size )->numParams(
$size )->text();
- $output = "<table style=\"line-height:70%;\" border=0
cellpadding=5 cellspacing=0 >
-<tr valign=\"bottom\">
-<td style=\"white-space:nowrap;overflow:hidden;\">{$plink}
{$dirmark}[$pages]</td>
-<td>
-<table style=\"line-height:70%;\" border=0 cellpadding=0 cellspacing=0 >
-<tr>
-<td width=\"2\"> </td>
-<td align=center class='quality4' width=\"$q4\"></td>
-<td align=center class='quality3' width=\"$q3\"></td>
-<td align=center class='quality2' width=\"$q2\"></td>
-<td align=center class='quality1' width=\"$q1\"></td>
-<td align=center class='quality0' width=\"$q0\"></td>
-$void_cell
-</tr></table>
-</td>
-</tr></table>";
-
- return $output;
+ return "<div style=\"display: table; border-spacing: 10px
0;\"><span style=\"display: table-cell;\">{$plink}
{$dirmark}[$pages]</span><span style=\"display:
table-cell;\">{$qualityOutput}</span></div>";
}
}
diff --git a/modules/article/ext.proofreadpage.article.css
b/modules/article/ext.proofreadpage.article.css
index 38a9ff1..cdc5c77 100644
--- a/modules/article/ext.proofreadpage.article.css
+++ b/modules/article/ext.proofreadpage.article.css
@@ -1,12 +1,3 @@
.pr_quality {
- border-collapse: separate;
- border-spacing: 0px 0px;
- border: 1px dotted #B8B8B8;
- text-align: center;
width: 100px;
-}
-
-.pr_quality td {
- padding: 0;
- height: 0.4em;
}
diff --git a/modules/ext.proofreadpage.base.css
b/modules/ext.proofreadpage.base.css
index b0165bb..9326741 100644
--- a/modules/ext.proofreadpage.base.css
+++ b/modules/ext.proofreadpage.base.css
@@ -13,4 +13,17 @@
}
.quality0 {
background-color: #ddd;
-}
\ No newline at end of file
+}
+
+.pr_quality {
+ border-collapse: separate;
+ border-spacing: 0 0;
+ border: 1px dotted #B8B8B8;
+ text-align: center;
+ max-width: 100%;
+}
+
+.pr_quality td {
+ padding: 0;
+ height: 0.6em;
+}
--
To view, visit https://gerrit.wikimedia.org/r/200870
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifdb772e6b9990c42a58b80eeb1eaf494d034c091
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ProofreadPage
Gerrit-Branch: master
Gerrit-Owner: Tpt <thoma...@hotmail.fr>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
