Krinkle has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/201085

Change subject: Parser: Say tildes instead of ~~~ in comment to fix Doxygen 
fatal
......................................................................

Parser: Say tildes instead of ~~~ in comment to fix Doxygen fatal

Doxygen was unable to parse the file past validateSig().

> Parser.php:6397: warning: reached end of file while inside a ~~~ block!
> The command that should end the block seems to be missing!

Change-Id: I3d1b547968302611d2bd78a7c11dd0738b40d23a
---
M includes/parser/Parser.php
M includes/parser/ParserOptions.php
2 files changed, 3 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/85/201085/1

diff --git a/includes/parser/Parser.php b/includes/parser/Parser.php
index 40b0a4f..8b988ef 100644
--- a/includes/parser/Parser.php
+++ b/includes/parser/Parser.php
@@ -4942,7 +4942,7 @@
        /**
         * Clean up signature text
         *
-        * 1) Strip ~~~, ~~~~ and ~~~~~ out of signatures @see cleanSigInSig
+        * 1) Strip  3, 4 or 5 tildes out of signatures @see cleanSigInSig
         * 2) Substitute all transclusions
         *
         * @param string $text
@@ -4981,7 +4981,7 @@
        }
 
        /**
-        * Strip ~~~, ~~~~ and ~~~~~ out of signatures
+        * Strip 3, 4 or 5 tildes out of signatures.
         *
         * @param string $text
         * @return string Signature text with /~{3,5}/ removed
diff --git a/includes/parser/ParserOptions.php 
b/includes/parser/ParserOptions.php
index 9e06ee2..209c597 100644
--- a/includes/parser/ParserOptions.php
+++ b/includes/parser/ParserOptions.php
@@ -145,9 +145,7 @@
 
        /**
         * Clean up signature texts?
-        *
-        * 1) Strip ~~~, ~~~~ and ~~~~~ out of signatures
-        * 2) Substitute all transclusions
+        * @see Parser::cleanSig
         */
        public $mCleanSignatures;
 

-- 
To view, visit https://gerrit.wikimedia.org/r/201085
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3d1b547968302611d2bd78a7c11dd0738b40d23a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle <krinklem...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to