jenkins-bot has submitted this change and it was merged. Change subject: Fix notices on bogus language codes ......................................................................
Fix notices on bogus language codes Bug: T93500 Change-Id: I1f6ef994b898e1eb133cc3fbbea7839adb9c57d6 --- M includes/specials/SpecialMobileLanguages.php 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Florianschmidtwelzow: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/specials/SpecialMobileLanguages.php b/includes/specials/SpecialMobileLanguages.php index 45d1995..f5d3e28 100644 --- a/includes/specials/SpecialMobileLanguages.php +++ b/includes/specials/SpecialMobileLanguages.php @@ -57,9 +57,15 @@ // Set the name of each lanugage based on the system list of language names $languageMap = Language::fetchLanguageNames(); $languages = $page['langlinks']; - foreach ( $languages as &$langObject ) { + foreach ( $page['langlinks'] as $code => $langObject ) { + if ( !isset( $languageMap[$langObject['lang']] ) ) { + // Bug T93500: DB might still have preantiquated rows with bogus languages + unset( $languages[$code] ); + continue; + } $langObject['langname'] = $languageMap[$langObject['lang']]; $langObject['url'] = MobileContext::singleton()->getMobileUrl( $langObject['url'] ); + $languages[$code] = $langObject; } return $languages; } else { -- To view, visit https://gerrit.wikimedia.org/r/199177 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f6ef994b898e1eb133cc3fbbea7839adb9c57d6 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: MaxSem <maxsem.w...@gmail.com> Gerrit-Reviewer: Florianschmidtwelzow <florian.schmidt.wel...@t-online.de> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits