Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/201195
Change subject: Fix possible crash(es) when highlighting text to share.
......................................................................
Fix possible crash(es) when highlighting text to share.
Bug: T94311
Change-Id: I9f45dc87c3971b42955216f12a57f3605e09fbe8
---
M
wikipedia/src/main/java/org/wikipedia/page/snippet/TextSelectedShareAdapter.java
1 file changed, 7 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/95/201195/1
diff --git
a/wikipedia/src/main/java/org/wikipedia/page/snippet/TextSelectedShareAdapter.java
b/wikipedia/src/main/java/org/wikipedia/page/snippet/TextSelectedShareAdapter.java
index d77e80b..4971b36 100644
---
a/wikipedia/src/main/java/org/wikipedia/page/snippet/TextSelectedShareAdapter.java
+++
b/wikipedia/src/main/java/org/wikipedia/page/snippet/TextSelectedShareAdapter.java
@@ -81,14 +81,14 @@
} else if (resourceName.contains("share")) {
shareItem = item;
}
+ // In APIs lower than 21, some of the action mode icons may
not respect the
+ // current theme, so we need to manually tint those icons.
+ if (Build.VERSION.SDK_INT < Build.VERSION_CODES.LOLLIPOP) {
+ fixMenuItemTheme(item);
+ }
} catch (Resources.NotFoundException e) {
- // Looks like some devices don't have "names" for these menu
items,
- // in which case, there's nothing we can do...
- }
- // In APIs lower than 21, some of the action mode icons may not
respect the
- // current theme, so we need to manually tint those icons.
- if (Build.VERSION.SDK_INT < Build.VERSION_CODES.LOLLIPOP) {
- fixMenuItemTheme(item);
+ // Looks like some devices don't provide access to these menu
items through
+ // the context of the app, in which case, there's nothing we
can do...
}
}
--
To view, visit https://gerrit.wikimedia.org/r/201195
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9f45dc87c3971b42955216f12a57f3605e09fbe8
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <dbr...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
