jenkins-bot has submitted this change and it was merged. Change subject: Remove superfluous statementview::cancelEditing ......................................................................
Remove superfluous statementview::cancelEditing EditableTemplatedWidget already provides that method. Change-Id: I0717f993f1e78ad70d33a70a20982dd50d6c20a4 --- M view/resources/jquery/wikibase/jquery.wikibase.statementview.js 1 file changed, 0 insertions(+), 10 deletions(-) Approvals: Thiemo Mättig (WMDE): Looks good to me, approved jenkins-bot: Verified diff --git a/view/resources/jquery/wikibase/jquery.wikibase.statementview.js b/view/resources/jquery/wikibase/jquery.wikibase.statementview.js index 3fc932b..c1405fb 100644 --- a/view/resources/jquery/wikibase/jquery.wikibase.statementview.js +++ b/view/resources/jquery/wikibase/jquery.wikibase.statementview.js @@ -757,16 +757,6 @@ }, /** - * Exits edit mode and restores the value from before the edit mode has been started. - * (Shortcut to `this.stopEditing( true )`) - * - * @return {undefined} - */ - cancelEditing: function() { - return this.stopEditing( true ); - }, - - /** * @inheritdoc */ isEmpty: function() { -- To view, visit https://gerrit.wikimedia.org/r/201187 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0717f993f1e78ad70d33a70a20982dd50d6c20a4 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Adrian Lang <adrian.he...@wikimedia.de> Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits