jenkins-bot has submitted this change and it was merged.
Change subject: OutputPage: Tiny tweak to jQuery.ready inline script
......................................................................
OutputPage: Tiny tweak to jQuery.ready inline script
Changing 'window.jQuery && jQuery.ready()' to 'if ( window.jQuery )
jQuery.ready()' means no *<![CDATA[*/ /*]]>* is required (because we
got rid of the ampersands). It's also more readable and more consistent
with if(window.mw).
Change-Id: I28262efb978c085e732b40f9dc5ddb1bda5c4376
---
M includes/OutputPage.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Krinkle: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/OutputPage.php b/includes/OutputPage.php
index edeae0d..1a4f5b7 100644
--- a/includes/OutputPage.php
+++ b/includes/OutputPage.php
@@ -3106,7 +3106,7 @@
// This also enforces $.isReady to be true at </body> which
fixes the
// mw.loader bug in Firefox with using document.write between
</body>
// and the DOMContentReady event (bug 47457).
- $html = Html::inlineScript( 'window.jQuery && jQuery.ready();'
);
+ $html = Html::inlineScript( 'if(window.jQuery)jQuery.ready();'
);
if ( !$this->getConfig()->get(
'ResourceLoaderExperimentalAsyncLoading' ) ) {
$html .= $this->getScriptsForBottomQueue( false );
--
To view, visit https://gerrit.wikimedia.org/r/201152
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I28262efb978c085e732b40f9dc5ddb1bda5c4376
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <[email protected]>
Gerrit-Reviewer: Daniel Friesen <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
