coren has submitted this change and it was merged.

Change subject: Labs: make net saturation monitoring configurable
......................................................................


Labs: make net saturation monitoring configurable

Defaulting to eth0 but set to bond0 for labstore1001

Change-Id: I0d010f9caf88a3b8720cc380d60d953026509995
---
M hieradata/hosts/labstore1001.yaml
M manifests/role/labsnfs.pp
2 files changed, 4 insertions(+), 3 deletions(-)

Approvals:
  Filippo Giunchedi: Looks good to me, but someone else must approve
  coren: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/hieradata/hosts/labstore1001.yaml 
b/hieradata/hosts/labstore1001.yaml
index 1b75a62..03930d6 100644
--- a/hieradata/hosts/labstore1001.yaml
+++ b/hieradata/hosts/labstore1001.yaml
@@ -1,3 +1,4 @@
 base::resolving::domain_search:
   - wikimedia.org
   - eqiad.wmnet
+role::labs::nfs::fileserver::monitor_iface: bond0
diff --git a/manifests/role/labsnfs.pp b/manifests/role/labsnfs.pp
index 9a67d69..dd3ab9b 100644
--- a/manifests/role/labsnfs.pp
+++ b/manifests/role/labsnfs.pp
@@ -37,7 +37,7 @@
 # The role class for the NFS servers that provide general filesystem
 # services to Labs.
 #
-class role::labs::nfs::fileserver {
+class role::labs::nfs::fileserver($monitor_iface = 'eth0') {
     include standard
 
     # eqiad still uses LDAP for now
@@ -55,7 +55,7 @@
 
     monitoring::graphite_threshold { 'network_out_saturated':
         description => 'Outgoing network saturation',
-        metric      => "servers.${::hostname}.network.bond0.tx_byte.value",
+        metric      => 
"servers.${::hostname}.network.${monitor_iface}.tx_byte.value",
         from        => '30min',
         warning     => '75000000',  # roughly 600Mbps / 1Gbps
         critical    => '100000000', # roughly 800Mbps / 1Gbps
@@ -64,7 +64,7 @@
 
     monitoring::graphite_threshold { 'network_in_saturated':
         description => 'Incoming network saturation',
-        metric      => "servers.${::hostname}.network.bond0.rx_byte.value",
+        metric      => 
"servers.${::hostname}.network.${monitor_iface}.rx_byte.value",
         from        => '30min',
         warning     => '75000000',  # roughly 600Mbps / 1Gbps
         critical    => '100000000', # roughly 800Mbps / 1Gbps

-- 
To view, visit https://gerrit.wikimedia.org/r/201232
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0d010f9caf88a3b8720cc380d60d953026509995
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: coren <[email protected]>
Gerrit-Reviewer: Filippo Giunchedi <[email protected]>
Gerrit-Reviewer: coren <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to