jenkins-bot has submitted this change and it was merged.

Change subject: Remove ContentFixers from Parsoid API
......................................................................


Remove ContentFixers from Parsoid API

Those ContentFixers are very Flow-specific. They're workarounds
for the fact that we store static HTML that can't reflect
changes in links (redlinks, bad images), or for the location
we serve them at (we can't wrap <base href> in <head>)

None of those fixers apply to VE (which actually is Parsoid's
main consumer, so bare Parsoid should likely work best)

Preview also used to use this API (and that one needed the
content fixes), but that's being removed as we use VE.

Bug: T93814
Change-Id: I915634ca51f330cd80bac749658ba9b19109c68f
---
M includes/Api/ApiParsoidUtilsFlow.php
1 file changed, 0 insertions(+), 6 deletions(-)

Approvals:
  Mattflaschen: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/Api/ApiParsoidUtilsFlow.php 
b/includes/Api/ApiParsoidUtilsFlow.php
index d24dcc4..d16ccc5 100644
--- a/includes/Api/ApiParsoidUtilsFlow.php
+++ b/includes/Api/ApiParsoidUtilsFlow.php
@@ -23,12 +23,6 @@
                        return; // helps static analysis know execution does 
not continue past self::dieUsage
                }
 
-               if ( $params['to'] === 'html' ) {
-                       /** @var ContentFixer $contentFixer */
-                       $contentFixer = Container::get( 'content_fixer' );
-                       $content = $contentFixer->apply( $content, 
$page->getTitle() );
-               }
-
                $result = array(
                        'format' => $params['to'],
                        'content' => $content,

-- 
To view, visit https://gerrit.wikimedia.org/r/201158
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I915634ca51f330cd80bac749658ba9b19109c68f
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie <mmul...@wikimedia.org>
Gerrit-Reviewer: Legoktm <legoktm.wikipe...@gmail.com>
Gerrit-Reviewer: Mattflaschen <mflasc...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to