jenkins-bot has submitted this change and it was merged. Change subject: Unify variable function params docs ......................................................................
Unify variable function params docs See https://github.com/wmde/WikibaseDataModel/pull/395 Change-Id: Ia870d2708fea84e10ae8fc58c82f86f47ab45171 --- M client/includes/parserhooks/NoLangLinkHandler.php M repo/includes/GenericEventDispatcher.php M repo/includes/api/ApiErrorReporter.php M repo/includes/api/ApiWikibase.php M repo/includes/updates/DataUpdateAdapter.php M repo/tests/phpunit/includes/api/WikibaseApiTestCase.php M view/src/EntityViewPlaceholderExpander.php M view/src/Template/TemplateFactory.php M view/src/TextInjector.php 9 files changed, 9 insertions(+), 9 deletions(-) Approvals: Addshore: Looks good to me, approved jenkins-bot: Verified diff --git a/client/includes/parserhooks/NoLangLinkHandler.php b/client/includes/parserhooks/NoLangLinkHandler.php index e479466..eea4136 100644 --- a/client/includes/parserhooks/NoLangLinkHandler.php +++ b/client/includes/parserhooks/NoLangLinkHandler.php @@ -34,7 +34,7 @@ * * @return string */ - public static function handle( &$parser ) { + public static function handle( &$parser /*...*/ ) { $langs = func_get_args(); // Remove the first member, which is the parser. diff --git a/repo/includes/GenericEventDispatcher.php b/repo/includes/GenericEventDispatcher.php index d5b859b..11ddcc8 100644 --- a/repo/includes/GenericEventDispatcher.php +++ b/repo/includes/GenericEventDispatcher.php @@ -82,7 +82,7 @@ * * @throws InvalidArgumentException */ - public function dispatch( $event ) { + public function dispatch( $event /*...*/ ) { if ( !is_string( $event ) ) { throw new InvalidArgumentException( '$event must be a string' ); } diff --git a/repo/includes/api/ApiErrorReporter.php b/repo/includes/api/ApiErrorReporter.php index 311852d..330ad17 100644 --- a/repo/includes/api/ApiErrorReporter.php +++ b/repo/includes/api/ApiErrorReporter.php @@ -189,7 +189,7 @@ * * @throws LogicException */ - public function dieMessage( $errorCode ) { + public function dieMessage( $errorCode /*...*/ ) { $messageName = "wikibase-api-$errorCode"; $params = func_get_args(); array_shift( $params ); diff --git a/repo/includes/api/ApiWikibase.php b/repo/includes/api/ApiWikibase.php index fd83280..207d251 100644 --- a/repo/includes/api/ApiWikibase.php +++ b/repo/includes/api/ApiWikibase.php @@ -516,7 +516,7 @@ * @param string $errorCode A code identifying the error. * @param string [$param,...] Parameters for the Message. */ - protected function dieMessage( $errorCode ) { + protected function dieMessage( $errorCode /*...*/ ) { call_user_func_array( array( $this->errorReporter, 'dieMessage' ), func_get_args() ); } diff --git a/repo/includes/updates/DataUpdateAdapter.php b/repo/includes/updates/DataUpdateAdapter.php index beb2fb3..f592e8d 100644 --- a/repo/includes/updates/DataUpdateAdapter.php +++ b/repo/includes/updates/DataUpdateAdapter.php @@ -43,7 +43,7 @@ * * @throws InvalidArgumentException */ - public function __construct( $doUpdateFunction ) { + public function __construct( $doUpdateFunction /*...*/ ) { if ( !is_callable( $doUpdateFunction ) ) { throw new InvalidArgumentException( '$doUpdateFunction must be callable' ); } diff --git a/repo/tests/phpunit/includes/api/WikibaseApiTestCase.php b/repo/tests/phpunit/includes/api/WikibaseApiTestCase.php index 69a72a8..5987df7 100644 --- a/repo/tests/phpunit/includes/api/WikibaseApiTestCase.php +++ b/repo/tests/phpunit/includes/api/WikibaseApiTestCase.php @@ -326,7 +326,7 @@ * @param array $response * @param string [$path,...] path elements (optional) */ - public function assertResultHasKeyInPath( $response ) { + public function assertResultHasKeyInPath( $response /*...*/ ) { $path = func_get_args(); array_shift( $path ); diff --git a/view/src/EntityViewPlaceholderExpander.php b/view/src/EntityViewPlaceholderExpander.php index 9ca39f2..00f2e2d 100644 --- a/view/src/EntityViewPlaceholderExpander.php +++ b/view/src/EntityViewPlaceholderExpander.php @@ -157,7 +157,7 @@ * * @return string HTML to be substituted for the placeholder in the output. */ - public function getHtmlForPlaceholder( $name ) { + public function getHtmlForPlaceholder( $name /*...*/ ) { $args = func_get_args(); $name = array_shift( $args ); diff --git a/view/src/Template/TemplateFactory.php b/view/src/Template/TemplateFactory.php index 49ad998..caab761 100644 --- a/view/src/Template/TemplateFactory.php +++ b/view/src/Template/TemplateFactory.php @@ -42,7 +42,7 @@ * * @return string */ - public function render( $key /* ... */ ) { + public function render( $key /*...*/ ) { $params = func_get_args(); array_shift( $params ); diff --git a/view/src/TextInjector.php b/view/src/TextInjector.php index fa72e26..80fb7d9 100644 --- a/view/src/TextInjector.php +++ b/view/src/TextInjector.php @@ -52,7 +52,7 @@ * * @return string */ - public function newMarker( $name /* ... */ ) { + public function newMarker( $name /*...*/ ) { $marker = '$' . $this->uniqPrefix . '#' . ++$this->markerIndex . '$'; $args = func_get_args(); -- To view, visit https://gerrit.wikimedia.org/r/194207 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia870d2708fea84e10ae8fc58c82f86f47ab45171 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de> Gerrit-Reviewer: Addshore <addshorew...@gmail.com> Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
