Markus Kroetzsch has uploaded a new change for review. Change subject: Fixed Bug 42032 ......................................................................
Fixed Bug 42032 The bug is caused by more than one entry referring to special properties in the SMW IDs table. There are multiple reasons why this has happened: * Predefined properties are stored by their keys (e.g., _TYPE) but if they also have a property page, this page will be called like their current label (e.g., "has type"); this was not matched * The refresh script carelessly created refresh jobs even for predefined properties, thus refreshing pages with titles like "TYPE" that never existed. Both problems surfaced due to the new way of producing Special:Properties. The new code requires Store3 to be reset and recreated to fix any existing problems caused by the earlier misbehaviour. A simple refresh is not going to delete the obsolete ID entries. Note for review: SMW_Sql3SmwIds.php applies some inconsistent naming for new symbols. The old ones should be fixed in another commit, but this is not release critical and would require more far-reaching changes since some of the methods that should be renamed are public. Can be done in SMW 1.9. Change-Id: Ifd6267cbd3fca1c3bee1b1927c70b91bd8128356 --- M includes/dataitems/SMW_DI_Property.php M includes/storage/SQLStore/SMW_SQLStore3_SetupHandlers.php M includes/storage/SQLStore/SMW_Sql3SmwIds.php 3 files changed, 234 insertions(+), 102 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/11/34211/1 -- To view, visit https://gerrit.wikimedia.org/r/34211 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifd6267cbd3fca1c3bee1b1927c70b91bd8128356 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch <mar...@semantic-mediawiki.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
