jenkins-bot has submitted this change and it was merged. Change subject: MenuLayout: Correct documentation ......................................................................
MenuLayout: Correct documentation * 'position' is actually 'menuPosition'. * 'collapse' doesn't exist. Change-Id: Ieb6bef8a2b365e54e4cafcce97b55a89b931a4cf --- M src/layouts/MenuLayout.js 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Jforrester: Looks good to me, approved jenkins-bot: Verified diff --git a/src/layouts/MenuLayout.js b/src/layouts/MenuLayout.js index d5bce45..306eebe 100644 --- a/src/layouts/MenuLayout.js +++ b/src/layouts/MenuLayout.js @@ -11,8 +11,7 @@ * @param {Object} [config] Configuration options * @cfg {number|string} [menuSize='18em'] Size of menu in pixels or any CSS unit * @cfg {boolean} [showMenu=true] Show menu - * @cfg {string} [position='before'] Position of menu, either `top`, `after`, `bottom` or `before` - * @cfg {boolean} [collapse] Collapse the menu out of view + * @cfg {string} [menuPosition='before'] Position of menu: `top`, `after`, `bottom` or `before` */ OO.ui.MenuLayout = function OoUiMenuLayout( config ) { var positions = this.constructor.static.menuPositions; -- To view, visit https://gerrit.wikimedia.org/r/201166 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb6bef8a2b365e54e4cafcce97b55a89b931a4cf Gerrit-PatchSet: 1 Gerrit-Project: oojs/ui Gerrit-Branch: master Gerrit-Owner: Bartosz DziewoĆski <matma....@gmail.com> Gerrit-Reviewer: Esanders <esand...@wikimedia.org> Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits