Catrope has submitted this change and it was merged. Change subject: Always apply inspected annotations to the right range ......................................................................
Always apply inspected annotations to the right range When you leave the inspector by changing the selection, we need to apply changes to the old selection. ve.ui.Inspector * Added initialSelection * Change getMatchingAnnotations to use a given fragment rather than generating it's own * Set initialSelection on open ve.ui.Context * Make hiding the context accept changes ve.ui.LinkInspector * Passing a fragment into getMatchingAnnotations now * Using fragment API instead of actions API to control the range of the fragment Change-Id: If6c8845285d87d0f144b15d50c38e192c797be59 --- M modules/ve/ui/inspectors/ve.ui.LinkInspector.js M modules/ve/ui/ve.ui.Context.js M modules/ve/ui/ve.ui.Inspector.js 3 files changed, 18 insertions(+), 11 deletions(-) Approvals: Catrope: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/34244 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6c8845285d87d0f144b15d50c38e192c797be59 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Trevor Parscal <[email protected]> Gerrit-Reviewer: Catrope <[email protected]> Gerrit-Reviewer: Trevor Parscal <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
