Subramanya Sastry has submitted this change and it was merged.

Change subject: Fix a crasher on [[Faraday-Lenz law]]
......................................................................


Fix a crasher on [[Faraday-Lenz law]]

The extension content handlers were all registered with the same rank, which
caused removeTransform calls to only remove one of those transforms. This
caused a crash on [[Faraday-Lenz law]] and possibly other pages
(http://parsoid.wmflabs.org:8001/result/b91dc07cd0132da4b2daf3f0bc99a20912931130/Faraday-Lenz%20law).

This patch slightly increments the rank for each extension, which fixes the
crash.

Change-Id: Ied38b2547c98c00d159b894bd7b127a4d91362c7
---
M js/lib/ext.ExtensionContentCollector.js
M js/lib/ext.util.TokenCollector.js
2 files changed, 8 insertions(+), 2 deletions(-)

Approvals:
  Subramanya Sastry: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/34228
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ied38b2547c98c00d159b894bd7b127a4d91362c7
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: GWicke <[email protected]>
Gerrit-Reviewer: GWicke <[email protected]>
Gerrit-Reviewer: Subramanya Sastry <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to