Santhosh has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/202673

Change subject: Move the highlighting related styles to a separate LESS file
......................................................................

Move the highlighting related styles to a separate LESS file

It was duplicated in source and translation modules

Change-Id: I2692ce19d6c55b12d90edac464514167bf64010d
---
M modules/source/styles/ext.cx.source.less
M modules/translation/styles/ext.cx.translation.less
A modules/widgets/common/ext.cx.highlight.less
3 files changed, 26 insertions(+), 50 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation 
refs/changes/73/202673/1

diff --git a/modules/source/styles/ext.cx.source.less 
b/modules/source/styles/ext.cx.source.less
index 551bb62..7207a96 100644
--- a/modules/source/styles/ext.cx.source.less
+++ b/modules/source/styles/ext.cx.source.less
@@ -1,8 +1,5 @@
 @import "../../widgets/common/ext.cx.common";
-
-@text-highlight-color: #FEFCE0;
-@link-highlight-color: #BDD4FF;
-@connected-link-highlight-color: #D9E6FF;
+@import "../../widgets/common/ext.cx.highlight";
 
 .cx-column--source {
        .cx-column__language-label,
@@ -19,27 +16,6 @@
 
        .cx-column__sub-heading__view-page {
                .mw-ui-two-thirds;
-       }
-
-       .cx-highlight {
-               background-color: @text-highlight-color;
-               box-shadow: 0px 0px 0 2px @text-highlight-color;
-               border-radius: 2px;
-               transition: all 0.25s;
-       }
-
-       .cx-highlight--blue {
-               background-color: @link-highlight-color;
-               box-shadow: 0px 0px 0 2px @link-highlight-color;
-               border-radius: 2px;
-               transition: all 0.25s;
-       }
-
-       .cx-highlight--lightblue {
-               background-color: @connected-link-highlight-color;
-               box-shadow: 0px 0px 0 2px @connected-link-highlight-color;
-               border-radius: 2px;
-               transition: all 0.25s;
        }
 }
 
diff --git a/modules/translation/styles/ext.cx.translation.less 
b/modules/translation/styles/ext.cx.translation.less
index 35c2417..6c77190 100644
--- a/modules/translation/styles/ext.cx.translation.less
+++ b/modules/translation/styles/ext.cx.translation.less
@@ -1,8 +1,5 @@
 @import "../../widgets/common/ext.cx.common";
-
-@text-highlight-color: #FEFCE0;
-@link-highlight-color: #BDD4FF;
-@connected-link-highlight-color: #D9E6FF;
+@import "../../widgets/common/ext.cx.highlight";
 
 .cx-column--translation {
        [contenteditable] {
@@ -11,27 +8,6 @@
 
        [data-editable=false] {
                 background-image: repeating-linear-gradient(135deg,#eee,#eee 
5px,#ddd 5px,#ddd 10px);
-       }
-
-       .cx-highlight {
-               background-color: @text-highlight-color;
-               box-shadow: 0px 0px 0 2px @text-highlight-color;
-               border-radius: 2px;
-               transition: all 0.25s;
-       }
-
-       .cx-highlight--blue {
-               background-color: @link-highlight-color;
-               box-shadow: 0px 0px 0 2px @link-highlight-color;
-               border-radius: 2px;
-               transition: all 0.25s;
-       }
-
-       .cx-highlight--lightblue {
-               background-color: @connected-link-highlight-color;
-               box-shadow: 0px 0px 0 2px @connected-link-highlight-color;
-               border-radius: 2px;
-               transition: all 0.25s;
        }
 }
 
diff --git a/modules/widgets/common/ext.cx.highlight.less 
b/modules/widgets/common/ext.cx.highlight.less
new file mode 100644
index 0000000..f339809
--- /dev/null
+++ b/modules/widgets/common/ext.cx.highlight.less
@@ -0,0 +1,24 @@
+@text-highlight-color: #FEFCE0;
+@link-highlight-color: #BDD4FF;
+@connected-link-highlight-color: #D9E6FF;
+
+.cx-highlight {
+       background-color: @text-highlight-color;
+       box-shadow: 0px 0px 0 2px @text-highlight-color;
+       border-radius: 2px;
+       transition: all 0.25s;
+}
+
+.cx-highlight--blue {
+       background-color: @link-highlight-color;
+       box-shadow: 0px 0px 0 2px @link-highlight-color;
+       border-radius: 2px;
+       transition: all 0.25s;
+}
+
+.cx-highlight--lightblue {
+       background-color: @connected-link-highlight-color;
+       box-shadow: 0px 0px 0 2px @connected-link-highlight-color;
+       border-radius: 2px;
+       transition: all 0.25s;
+}

-- 
To view, visit https://gerrit.wikimedia.org/r/202673
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2692ce19d6c55b12d90edac464514167bf64010d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Santhosh <santhosh.thottin...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to