[MediaWiki-commits] [Gerrit] Code improvements - change (mediawiki...BlueSpiceSkin)

[Robert Vogel (Code Review)]

Robert Vogel has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/202685

Change subject: Code improvements
......................................................................

Code improvements

Now using parametized mixins instead of global scope variables

Change-Id: Ida4ebb57dab0fd8e40fd34f9193ade74196799b3
---
M resources/components/skin.icons.less
1 file changed, 9 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/BlueSpiceSkin 
refs/changes/85/202685/1

diff --git a/resources/components/skin.icons.less 
b/resources/components/skin.icons.less
index b9c4fa0..01784b7 100644
--- a/resources/components/skin.icons.less
+++ b/resources/components/skin.icons.less
@@ -25,7 +25,7 @@
        margin-right: 4px;
 }
 
-.icon-mixin() {
+.icon-mixin( @bg-pos-top ) {
        > a .icon24 {
                background-position: 0 @bg-pos-top;
        }
@@ -47,9 +47,8 @@
                        min-height: 24px;
                }
 
-               @bg-pos-top: -192px;
                li {
-                       .icon-mixin();
+                       .icon-mixin( -192px );
                }
 
                .bs-nav-item-text {
@@ -59,40 +58,33 @@
 
        li#n-mainpage,
        li#n-mainpage-description {
-               @bg-pos-top: -120px;
-               .icon-mixin();
+               .icon-mixin( -120px );
        }
 
        li#n-special-allpages{
-               @bg-pos-top: -72px;
-               .icon-mixin();
+               .icon-mixin( -72px );
        }
 
        li#n-special-categories {
-               @bg-pos-top: -48px;
-               .icon-mixin();
+               .icon-mixin( -48px );
        }
 
        li#n-special-recentchanges,
        li#n-recentchanges {
-               @bg-pos-top: -168px;
-               .icon-mixin();
+               .icon-mixin( -168px );
        }
 
        li#n-external-manuals,
        li#n-help{
-               @bg-pos-top: -96px;
-               .icon-mixin();
+               .icon-mixin( -96px );
        }
 
        li#n-external-support {
-               @bg-pos-top: -216px;
-               .icon-mixin();
+               .icon-mixin( -216px );
        }
 
        li#n-external-contact {
-               @bg-pos-top: -144px;
-               .icon-mixin();
+               .icon-mixin( -144px );
        }
        #bs-nav-tabs a{
                font-size: 210%;

-- 
To view, visit https://gerrit.wikimedia.org/r/202685
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ida4ebb57dab0fd8e40fd34f9193ade74196799b3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/BlueSpiceSkin
Gerrit-Branch: master
Gerrit-Owner: Robert Vogel <vo...@hallowelt.biz>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits