Amire80 has uploaded a new change for review. https://gerrit.wikimedia.org/r/202733
Change subject: Cleanup ContentTranslation.hooks.php ...................................................................... Cleanup ContentTranslation.hooks.php Whitespace, order and spelling. Change-Id: Ia94d6e93003c3f5452ca2f300bd74ae61075ea37 --- M ContentTranslation.hooks.php M ContentTranslation.php 2 files changed, 7 insertions(+), 8 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation refs/changes/33/202733/1 diff --git a/ContentTranslation.hooks.php b/ContentTranslation.hooks.php index 268239a..7b487d5 100644 --- a/ContentTranslation.hooks.php +++ b/ContentTranslation.hooks.php @@ -39,7 +39,6 @@ BetaFeatures::isFeatureEnabled( $user, 'cx' ); } - /** * Hook: BeforePageDisplay */ @@ -65,7 +64,7 @@ $out->addModules( 'ext.cx.redlink' ); } - // Add a hover menu for contributions link in personal tool bar + // Add a hover menu for the contributions link in personal toolbar $out->addModules( 'ext.cx.campaigns.contributionsmenu' ); // The current guided tours are only for the user namespace, @@ -147,13 +146,13 @@ $wgContentTranslationBrowserBlacklist, $wgContentTranslationTargetNamespace; - $vars['wgContentTranslationSiteTemplates'] = $wgContentTranslationSiteTemplates; $vars['wgContentTranslationTranslateInTarget'] = $wgContentTranslationTranslateInTarget; $vars['wgContentTranslationExperimentalFeatures'] = $wgContentTranslationExperimentalFeatures; $vars['wgContentTranslationDatabase'] = $wgContentTranslationDatabase; - $vars['wgContentTranslationTargetNamespace'] = $wgContentTranslationTargetNamespace; + $vars['wgContentTranslationSiteTemplates'] = $wgContentTranslationSiteTemplates; $vars['wgContentTranslationCampaigns'] = $wgContentTranslationCampaigns; $vars['wgContentTranslationBrowserBlacklist'] = $wgContentTranslationBrowserBlacklist; + $vars['wgContentTranslationTargetNamespace'] = $wgContentTranslationTargetNamespace; } /** @@ -170,8 +169,9 @@ /** * Hook: EditPage::showEditForm:initial */ - public static function newArticleCampign( EditPage $newPage, OutputPage $out ) { + public static function newArticleCampaign( EditPage $newPage, OutputPage $out ) { global $wgContentTranslationCampaigns, $wgContentTranslationEventLogging; + $user = $out->getUser(); if ( @@ -209,10 +209,10 @@ $out->addModules( array( 'ext.cx.betafeature.init', 'ext.cx.campaigns.contributionsmenu' ) ); + // This make sure the auto-open contribution menu shown exactly once. // and it is not in Special:CX $saveOptions['cx-know'] = true; - } return true; @@ -286,5 +286,4 @@ ), ) + $resourcePaths; } - } diff --git a/ContentTranslation.php b/ContentTranslation.php index c39e77d..a07d869 100644 --- a/ContentTranslation.php +++ b/ContentTranslation.php @@ -73,7 +73,7 @@ $GLOBALS['wgHooks']['ChangeTagsListActive'][] = 'ContentTranslationHooks::registerTags'; $GLOBALS['wgHooks']['UserSaveOptions'][] = 'ContentTranslationHooks::onSaveOptions'; $GLOBALS['wgHooks']['EditPage::showEditForm:initial'][] = - 'ContentTranslationHooks::newArticleCampign'; + 'ContentTranslationHooks::newArticleCampaign'; $GLOBALS['wgHooks']['ResourceLoaderTestModules'][] = 'ContentTranslationHooks::onResourceLoaderTestModules'; -- To view, visit https://gerrit.wikimedia.org/r/202733 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia94d6e93003c3f5452ca2f300bd74ae61075ea37 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/ContentTranslation Gerrit-Branch: master Gerrit-Owner: Amire80 <amir.ahar...@mail.huji.ac.il> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits