Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/202796
Change subject: rrd-navtiming: fix step argument for archive defs
......................................................................
rrd-navtiming: fix step argument for archive defs
step is specified in number of datapoints, not absolute number of seconds.
Change-Id: If35bb11bca0b9802e348fc4c949f991e35c3a4a1
---
M modules/webperf/files/rrd-navtiming
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/96/202796/1
diff --git a/modules/webperf/files/rrd-navtiming
b/modules/webperf/files/rrd-navtiming
index 4069113..2e1a54a 100755
--- a/modules/webperf/files/rrd-navtiming
+++ b/modules/webperf/files/rrd-navtiming
@@ -175,8 +175,8 @@
for metric in METRICS]
# List of round-robin archive ('RRA') definitions in rrdcreate format.
-ARCHIVES = ['RRA:AVERAGE:0.5:%d:%d' % (interval_length / ROWS, ROWS)
- for interval_length in INTERVALS]
+ARCHIVES = ['RRA:AVERAGE:0.5:%d:%d' % (interval / ROWS / step, ROWS)
+ for interval in INTERVALS]
def update_rrds(path):
@@ -247,7 +247,7 @@
args = [
rrd_file,
'--no-overwrite',
- '--step', str(STEP),
+ '--step', '%d' % STEP,
'--start', 'N'
] + SOURCES + ARCHIVES
try:
--
To view, visit https://gerrit.wikimedia.org/r/202796
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If35bb11bca0b9802e348fc4c949f991e35c3a4a1
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ori.livneh <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
