jenkins-bot has submitted this change and it was merged.
Change subject: Log huge write queries in CLI scripts
......................................................................
Log huge write queries in CLI scripts
* This is already done for web scripts, but with lower limits
Bug: T95382
Change-Id: I0fe14bcdaebc3568b0cb7af8084b7bfefeb82826
---
M maintenance/Maintenance.php
1 file changed, 7 insertions(+), 0 deletions(-)
Approvals:
Chad: Looks good to me, approved
jenkins-bot: Verified
diff --git a/maintenance/Maintenance.php b/maintenance/Maintenance.php
index a0ffcb2..a8dbd5f 100644
--- a/maintenance/Maintenance.php
+++ b/maintenance/Maintenance.php
@@ -38,6 +38,8 @@
$maintClass = false;
+use MediaWiki\Logger\LoggerFactory;
+
/**
* Abstract maintenance class for quickly writing and churning out
* maintenance scripts with minimal effort. All that _must_ be defined
@@ -612,6 +614,11 @@
$profiler->setTemplated( true );
Profiler::replaceStubInstance( $profiler );
}
+
+ $trxProfiler = Profiler::instance()->getTransactionProfiler();
+ $trxProfiler->setLogger( LoggerFactory::getInstance(
'DBPerformance' ) );
+ # Catch huge single updates that lead to slave lag
+ $trxProfiler->setExpectation( 'maxAffected', 1000, __METHOD__ );
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/202640
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0fe14bcdaebc3568b0cb7af8084b7bfefeb82826
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <asch...@wikimedia.org>
Gerrit-Reviewer: Chad <ch...@wikimedia.org>
Gerrit-Reviewer: Parent5446 <tylerro...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
