Jdlrobson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/203227

Change subject: Hygiene: Move buttonWithSpinner css to more natural place
......................................................................

Hygiene: Move buttonWithSpinner css to more natural place

Change-Id: I19af90bf6525ef8b7a65abbf1badf5ad9c545d4c
---
M includes/Resources.php
A less/buttonWithSpinner.less
M less/icons.less
3 files changed, 13 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/27/203227/1

diff --git a/includes/Resources.php b/includes/Resources.php
index fddcd6b..8b4884d 100644
--- a/includes/Resources.php
+++ b/includes/Resources.php
@@ -1014,10 +1014,15 @@
                ),
        ),
 
+       // Note: Take care with loading this module as it will pull down OOJS 
UI in addition
+       // to our own code.
        'mobile.buttonWithSpinner' => $wgMFResourceFileModuleBoilerplate + 
array(
                        'dependencies' => array(
                                'oojs-ui',
                        ),
+                       'styles' => array(
+                               'less/buttonWithSpinner.less',
+                       ),
                        'scripts' => array(
                                'javascripts/ButtonWithSpinner.js',
                        ),
diff --git a/less/buttonWithSpinner.less b/less/buttonWithSpinner.less
new file mode 100644
index 0000000..bc85afa
--- /dev/null
+++ b/less/buttonWithSpinner.less
@@ -0,0 +1,8 @@
+@import "minerva.mixins";
+
+.oo-ui-indicator-spinner {
+       .background-image('images/ajax-loader.gif');
+       .background-size(100%, 100%);
+       margin-left: 0 !important;
+       margin-right: 0 !important;
+}
diff --git a/less/icons.less b/less/icons.less
index ba586a9..3c36821 100644
--- a/less/icons.less
+++ b/less/icons.less
@@ -242,10 +242,3 @@
 .icon-mainmenu {
        .background-image-svg( 'images/menu/hamburger.svg', 
'images/menu/hamburger.png' );
 }
-
-.oo-ui-indicator-spinner {
-       .background-image('images/ajax-loader.gif');
-       .background-size(100%, 100%);
-       margin-left: 0 !important;
-       margin-right: 0 !important;
-}

-- 
To view, visit https://gerrit.wikimedia.org/r/203227
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I19af90bf6525ef8b7a65abbf1badf5ad9c545d4c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to