Welterkj has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/203535

Change subject: Handle null revision in titleHasMultipleRevisions(). Bug: T89325
......................................................................

Handle null revision in titleHasMultipleRevisions().
Bug: T89325

Change-Id: Ic7d0f51ebf9506b6f03965d8cccf9bbbd26c74ea
---
M GraphViz_body.php
M RELEASE-NOTES.md
2 files changed, 9 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GraphViz 
refs/changes/35/203535/1

diff --git a/GraphViz_body.php b/GraphViz_body.php
index a84aac8..ba61ec1 100644
--- a/GraphViz_body.php
+++ b/GraphViz_body.php
@@ -391,7 +391,11 @@
         * @return true if the given title has multiple revisions, otherwise 
false.
         */
        public static function titleHasMultipleRevisions( $title ) {
-               return $title->getLatestRevID() != 
$title->getFirstRevision()->getId();
+               $firstRev = $title->getFirstRevision();
+               if ( $firstRev ) {
+                       return $title->getLatestRevID() != $firstRev->getId();
+               }
+               return false;
        }
 
        /**
diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md
index 13ac586..e094615 100644
--- a/RELEASE-NOTES.md
+++ b/RELEASE-NOTES.md
@@ -1,6 +1,9 @@
 These are the release notes for the [MediaWiki][mediawiki] [GraphViz 
extension][gv_ext].
 
-## GraphViz 1.6.0 ## (2015-3-26 )
+## GraphViz 1.6.1 ## (not released yet)
+* Fix for [bug T89325](https://phabricator.wikimedia.org/T89325).
+
+## GraphViz 1.6.0 ## (2015-3-26)
 * Make the category pages created by this extension optional, non-empty and do 
not tag “dummy” images as belonging to a category.
 * Allow DOT tooltips without URLs.
 

-- 
To view, visit https://gerrit.wikimedia.org/r/203535
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic7d0f51ebf9506b6f03965d8cccf9bbbd26c74ea
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GraphViz
Gerrit-Branch: master
Gerrit-Owner: Welterkj <welterkj+...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to