Filippo Giunchedi has uploaded a new change for review.
https://gerrit.wikimedia.org/r/203829
Change subject: varnishkafka: fix spurious UNKNOWN alert
......................................................................
varnishkafka: fix spurious UNKNOWN alert
statsite won't keep sending the last value over and over again like txstatsd,
it might then happen that there's no data between minutes, this in turn can
cause the alarm to turn UNKNOWN if >1/2 of datapoints are null.
Bug: T90111
Change-Id: I717b5ea303e8fa71cb52b92339906a36ae9e89eb
---
M manifests/role/cache.pp
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/29/203829/1
diff --git a/manifests/role/cache.pp b/manifests/role/cache.pp
index 8f9007a..6e558b3 100644
--- a/manifests/role/cache.pp
+++ b/manifests/role/cache.pp
@@ -528,7 +528,7 @@
# (logster only reports once a minute)
monitoring::graphite_threshold { 'varnishkafka-kafka_drerr':
description => 'Varnishkafka Delivery Errors per minute',
- metric =>
"derivative(${graphite_metric_prefix}.varnishkafka.kafka_drerr)",
+ metric =>
"derivative(transformNull(${graphite_metric_prefix}.varnishkafka.kafka_drerr),
0)",
# warn if more than 0 errors per minute in the last 10 minutes
warning => 0,
# critical if more than 20000 errors per minute in the last 10
minutes
--
To view, visit https://gerrit.wikimedia.org/r/203829
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I717b5ea303e8fa71cb52b92339906a36ae9e89eb
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Filippo Giunchedi <fgiunch...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
