Filippo Giunchedi has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/203839

Change subject: deprecate statsd meters
......................................................................

deprecate statsd meters

statsite doesn't support meters, switch to gauges instead. This also means that
generated metrics lose their '.count' suffix.

Bug: T90111
Change-Id: I20e1da2c85379ee410786f2d4382f7de706e6017
---
M server/bin/eventlogging-reporter
M server/eventlogging/handlers.py
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/EventLogging 
refs/changes/39/203839/1

diff --git a/server/bin/eventlogging-reporter b/server/bin/eventlogging-reporter
index 37e69a1..36e066c 100755
--- a/server/bin/eventlogging-reporter
+++ b/server/bin/eventlogging-reporter
@@ -137,7 +137,7 @@
                     os.read(fd, 8)
                     for name, value in counts.iteritems():
                         if value:
-                            stat = '%s.%s:%s|m' % (args.prefix, name, value)
+                            stat = '%s.%s:%s|g' % (args.prefix, name, value)
                             sock.sendto(stat.encode('utf-8'), addr)
                     counts.clear()
         except KeyboardInterrupt:
diff --git a/server/eventlogging/handlers.py b/server/eventlogging/handlers.py
index b08fdd0..c5fc26e 100644
--- a/server/eventlogging/handlers.py
+++ b/server/eventlogging/handlers.py
@@ -154,7 +154,7 @@
     sock = socket.socket(socket.AF_INET, socket.SOCK_DGRAM)
     while 1:
         event = (yield)
-        stat = prefix + '.%(schema)s:1|m' % event
+        stat = prefix + '.%(schema)s:+1|g' % event
         sock.sendto(stat.encode('utf-8'), addr)
 
 

-- 
To view, visit https://gerrit.wikimedia.org/r/203839
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I20e1da2c85379ee410786f2d4382f7de706e6017
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/EventLogging
Gerrit-Branch: master
Gerrit-Owner: Filippo Giunchedi <fgiunch...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to