Jdlrobson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/203842

Change subject: Prevent auto-reopening of collection overlay
......................................................................

Prevent auto-reopening of collection overlay

When render is called without options, this.options is used so this
is what should be deleted.

Bug: T95744
Change-Id: I1ce9b9b2ab12b71590b23de124d1628e828b57d4
---
M resources/ext.gather.watchstar/CollectionsWatchstar.js
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Gather 
refs/changes/42/203842/1

diff --git a/resources/ext.gather.watchstar/CollectionsWatchstar.js 
b/resources/ext.gather.watchstar/CollectionsWatchstar.js
index 66a445d..9e7099c 100644
--- a/resources/ext.gather.watchstar/CollectionsWatchstar.js
+++ b/resources/ext.gather.watchstar/CollectionsWatchstar.js
@@ -67,13 +67,12 @@
                /** @inheritdoc */
                postRender: function ( options ) {
                        var $el = this.$el;
-
                        // For newly authenticated users via CTA force dialog 
to open.
                        if ( options.isNewlyAuthenticatedUser ) {
                                setTimeout( function () {
                                        $el.trigger( 'click' );
                                }, 500 );
-                               delete options.isNewlyAuthenticatedUser;
+                               delete this.options.isNewlyAuthenticatedUser;
                        }
                        $el.removeClass( 'hidden' );
                },

-- 
To view, visit https://gerrit.wikimedia.org/r/203842
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1ce9b9b2ab12b71590b23de124d1628e828b57d4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Gather
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to