Jonaskeutel has submitted this change and it was merged.
Change subject: Removed bug in HtmlTableCell class, which leads to horizontal
arranged rows in Firefox and Opera.
......................................................................
Removed bug in HtmlTableCell class, which leads to horizontal arranged rows in
Firefox and Opera.
Changed default value of html attributes 'rowspan' and 'colspan' from 0 to 1.
Change-Id: I86d4e3f319085b12e26f45ca2948256ca90de2fa
---
M includes/Html/HtmlTableCell.php
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Jonaskeutel: Verified; Looks good to me, approved
diff --git a/includes/Html/HtmlTableCell.php b/includes/Html/HtmlTableCell.php
index f654fed..bcaa2b4 100644
--- a/includes/Html/HtmlTableCell.php
+++ b/includes/Html/HtmlTableCell.php
@@ -36,8 +36,10 @@
/**
* @param $content
+ * @param int $rowSpan
+ * @param int $colSpan
*/
- public function __construct( $content, $rowSpan = 0, $colSpan = 0 ) {
+ public function __construct( $content, $rowSpan = 1, $colSpan = 1 ) {
// Check parameters
if ( !is_string( $content ) ) {
throw new InvalidArgumentException( '$content must be string.' );
--
To view, visit https://gerrit.wikimedia.org/r/204025
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I86d4e3f319085b12e26f45ca2948256ca90de2fa
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikidataQuality
Gerrit-Branch: master
Gerrit-Owner: Soeren.oldag <soeren_ol...@freenet.de>
Gerrit-Reviewer: Jonaskeutel <jonas.keu...@student.hpi.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
