Glaisher has uploaded a new change for review.
https://gerrit.wikimedia.org/r/204083
Change subject: Special:CentralAuth: don't show global groups if 'none'
......................................................................
Special:CentralAuth: don't show global groups if 'none'
This is not really helpful/useful and adds to
confusion for new users. We already don't show stuff
like locked, hidden if it's not needed.
Change-Id: I2233e538434fdd762662a64fbc4c1477ed5832bd
---
M i18n/en.json
M i18n/qqq.json
M includes/specials/SpecialCentralAuth.php
3 files changed, 1 insertion(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralAuth
refs/changes/83/204083/1
diff --git a/i18n/en.json b/i18n/en.json
index ef00851..6707098 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -117,7 +117,6 @@
"centralauth-admin-info-locked": "Locked:",
"centralauth-admin-info-hidden": "Hidden level:",
"centralauth-admin-info-groups": "Global {{PLURAL:$1|group|groups}}:",
- "centralauth-admin-info-nogroups": "none",
"centralauth-admin-info-attached": "Number of attached accounts:",
"centralauth-admin-info-unattached": "Number of unattached accounts:",
"centralauth-admin-yes": "yes",
diff --git a/i18n/qqq.json b/i18n/qqq.json
index f728a6c..3adb3b2 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -132,8 +132,7 @@
"centralauth-admin-info-editcount": "Label of information shown in box
of 'Global user info' on
[{{canonicalurl:meta:Special:CentralAuth|target=Siebrand}} Global user manager]
special page.",
"centralauth-admin-info-locked": "Label of information shown in box of
'Global user info' on
[{{canonicalurl:meta:Special:CentralAuth|target=Siebrand}} Global user manager]
special page. The following messages can appear after the
colon:\n*{{msg-mw|Centralauth-admin-yes}}\n*{{msg-mw|Centralauth-admin-no}}",
"centralauth-admin-info-hidden": "Label of information on status of
user, recording whether the user is hidden to anyone but users with the right
'oversight'. Used on [{{canonicalurl:meta:Special:CentralAuth|target=Siebrand}}
Global user manager special page]. The following messages can appear after the
colon:\n*{{msg-mw|Centralauth-admin-hidden-oversight}}\n*{{msg-mw|Centralauth-admin-hidden-list}}\n*{{msg-mw|Centralauth-admin-no}}\n\n{{Identical|Hidden}}",
- "centralauth-admin-info-groups": "Label of information shown in box of
'Global user info' on
[{{canonicalurl:meta:Special:CentralAuth|target=Siebrand}} Global user manager]
special page.\n\nA comma separated list will follow the message, or
{{msg-mw|Centralauth-admin-info-nogroups}}\n\nParameters:\n* $1 - the number of
groups the user is in",
- "centralauth-admin-info-nogroups": "Shown when the user is not a member
of any global groups.\n{{Identical|None}}",
+ "centralauth-admin-info-groups": "Label of information shown in box of
'Global user info' on
[{{canonicalurl:meta:Special:CentralAuth|target=Siebrand}} Global user manager]
special page.\n\nA comma separated list will follow the
message.\n\nParameters:\n* $1 - the number of groups the user is in",
"centralauth-admin-info-attached": "Label of information shown in box
of 'Global user info' on
[{{canonicalurl:meta:Special:CentralAuth|target=Siebrand}} Global user manager]
special page.",
"centralauth-admin-info-unattached": "Label of information shown in box
of 'Global user info' on
[{{canonicalurl:meta:Special:CentralAuth|target=Siebrand}} Global user manager]
special page.",
"centralauth-admin-yes": "Used in box of 'Global user info' on
[{{canonicalurl:meta:Special:CentralAuth|target=Siebrand}} Global user manager]
special page. Can appear after
{{msg-mw|Centralauth-admin-info-locked}}\n{{Identical|Yes}}",
diff --git a/includes/specials/SpecialCentralAuth.php
b/includes/specials/SpecialCentralAuth.php
index 0517791..ea773cf 100644
--- a/includes/specials/SpecialCentralAuth.php
+++ b/includes/specials/SpecialCentralAuth.php
@@ -314,8 +314,6 @@
);
}, $groups );
$attribs['groups'] = $this->getLanguage()->commaList(
$groups );
- } else {
- $attribs['groups'] = $this->msg(
'centralauth-admin-info-nogroups' )->escaped();
}
return $attribs;
--
To view, visit https://gerrit.wikimedia.org/r/204083
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2233e538434fdd762662a64fbc4c1477ed5832bd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralAuth
Gerrit-Branch: master
Gerrit-Owner: Glaisher <glaisher.w...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
