jenkins-bot has submitted this change and it was merged. Change subject: Remove debug code from LangLinkHandler ......................................................................
Remove debug code from LangLinkHandler We no longer use this debug logging, and haven't had need for it in quite some time. Change-Id: Ib6ec4f0482e1e7bd4a694ce7867b830d1e8de4fd --- M client/includes/LangLinkHandler.php 1 file changed, 0 insertions(+), 16 deletions(-) Approvals: Thiemo Mättig (WMDE): Looks good to me, but someone else must approve JanZerebecki: Looks good to me, approved jenkins-bot: Verified diff --git a/client/includes/LangLinkHandler.php b/client/includes/LangLinkHandler.php index af2c8a0..32505c8 100644 --- a/client/includes/LangLinkHandler.php +++ b/client/includes/LangLinkHandler.php @@ -113,17 +113,11 @@ * @return SiteLink[] A map of SiteLinks, indexed by global site id. */ public function getEntityLinks( Title $title ) { - wfDebugLog( __CLASS__, __FUNCTION__ . ": Looking for sitelinks defined by the " - . "corresponding item on the wikibase repo." ); - $links = array(); $itemId = $this->getItemIdForTitle( $title ); if ( $itemId !== null ) { - wfDebugLog( __CLASS__, __FUNCTION__ . ': Item ID for ' . $title->getFullText() - . ' is ' . $itemId->getSerialization() ); - //NOTE: SiteLinks we could get from $this->siteLinkLookup do not contain badges, // so we have to fetch the links from the Item. @@ -137,12 +131,7 @@ wfWarn( __METHOD__ . ": Could not load item " . $itemId->getSerialization() . " for " . $title->getFullText() ); } - } else { - wfDebugLog( __CLASS__, __FUNCTION__ . ": No corresponding item found for " - . $title->getFullText() ); } - - wfDebugLog( __CLASS__, __FUNCTION__ . ": Found " . count( $links ) . " links." ); return $links; } @@ -273,8 +262,6 @@ public function filterRepoLinksByGroup( array $repoLinks, array $allowedGroups ) { foreach ( $repoLinks as $wiki => $link ) { if ( !$this->siteStore->getSite( $wiki ) ) { - wfDebugLog( __CLASS__, __FUNCTION__ . ': skipping link to unknown site ' . $wiki ); - unset( $repoLinks[$wiki] ); continue; } @@ -282,9 +269,6 @@ $site = $this->siteStore->getSite( $wiki ); if ( !in_array( $site->getGroup(), $allowedGroups ) ) { - wfDebugLog( __CLASS__, __FUNCTION__ . ': skipping link to other group: ' . $wiki - . ' belongs to ' . $site->getGroup() ); - unset( $repoLinks[$wiki] ); continue; } -- To view, visit https://gerrit.wikimedia.org/r/204255 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib6ec4f0482e1e7bd4a694ce7867b830d1e8de4fd Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Aude <aude.w...@gmail.com> Gerrit-Reviewer: Aude <aude.w...@gmail.com> Gerrit-Reviewer: Daniel Kinzler <daniel.kinz...@wikimedia.de> Gerrit-Reviewer: JanZerebecki <jan.wikime...@zerebecki.de> Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits