jenkins-bot has submitted this change and it was merged. Change subject: Deal with inconsistent API response and infinite spinner ......................................................................
Deal with inconsistent API response and infinite spinner Bug: T95637 Change-Id: I6910fe5f219d518d3ec3df147f638ddf232b4dea --- M resources/ext.gather.api/CollectionsApi.js 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jhernandez: Looks good to me, approved jenkins-bot: Verified diff --git a/resources/ext.gather.api/CollectionsApi.js b/resources/ext.gather.api/CollectionsApi.js index 9cc8517..d35082d 100644 --- a/resources/ext.gather.api/CollectionsApi.js +++ b/resources/ext.gather.api/CollectionsApi.js @@ -105,6 +105,10 @@ }; return this.get( params ).then( function ( resp ) { + // Workaround for https://phabricator.wikimedia.org/T95741 + if ( !resp.query ) { + return []; + } return $.map( resp.query.pages, function ( page ) { page.heading = page.title; page.isMember = true; -- To view, visit https://gerrit.wikimedia.org/r/203387 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6910fe5f219d518d3ec3df147f638ddf232b4dea Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Gather Gerrit-Branch: master Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org> Gerrit-Reviewer: Jhernandez <jhernan...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits